feat(discover): Updates android devices mapping and update script to work without csv-parser#109669
Conversation
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
|
small note: not a change to frontend, |
…pdate-android-device-name-mapping
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
gggritso
left a comment
There was a problem hiding this comment.
Honestly I don't think it's the worst thing to have a CSV parser dev dependency! Also, I know this is silly but Python has a built-in CSV parser and this script is so short, converting it to Python would be easy, IMO.
Also, just as idle curiosity, is this process documented somewhere? I don't actually know where to get the CSV for the device names from
@gggritso updated to python! There's a comment on the process at the top of |
android_models.pywith latest device models to marketing name mappingscripts/extract-android-device-names.jshelper script to work withoutcsv-parser