Skip to content

feat(discover): Updates android devices mapping and update script to work without csv-parser#109669

Merged
edwardgou-sentry merged 6 commits intomasterfrom
egou/feat/update-android-device-name-mapping
Mar 3, 2026
Merged

feat(discover): Updates android devices mapping and update script to work without csv-parser#109669
edwardgou-sentry merged 6 commits intomasterfrom
egou/feat/update-android-device-name-mapping

Conversation

@edwardgou-sentry
Copy link
Contributor

  • Updates android_models.py with latest device models to marketing name mapping
  • Updates scripts/extract-android-device-names.js helper script to work without csv-parser

@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Mar 2, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2026

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@edwardgou-sentry
Copy link
Contributor Author

edwardgou-sentry commented Mar 2, 2026

small note: not a change to frontend, scripts/extract-android-device-names.js is not used in any sentry service code path and intended to be used manually as a helper tool by contributors

@edwardgou-sentry edwardgou-sentry requested a review from a team March 2, 2026 19:01
@edwardgou-sentry edwardgou-sentry marked this pull request as ready for review March 2, 2026 19:01
@edwardgou-sentry edwardgou-sentry requested a review from a team as a code owner March 2, 2026 19:01
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Copy link
Member

@gggritso gggritso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I don't think it's the worst thing to have a CSV parser dev dependency! Also, I know this is silly but Python has a built-in CSV parser and this script is so short, converting it to Python would be easy, IMO.

Also, just as idle curiosity, is this process documented somewhere? I don't actually know where to get the CSV for the device names from

@edwardgou-sentry
Copy link
Contributor Author

Honestly I don't think it's the worst thing to have a CSV parser dev dependency! Also, I know this is silly but Python has a built-in CSV parser and this script is so short, converting it to Python would be easy, IMO.

Also, just as idle curiosity, is this process documented somewhere? I don't actually know where to get the CSV for the device names from

@gggritso updated to python! There's a comment on the process at the top of android_models.py, also added to the top of the new script as well!

@edwardgou-sentry edwardgou-sentry merged commit 4e91888 into master Mar 3, 2026
78 checks passed
@edwardgou-sentry edwardgou-sentry deleted the egou/feat/update-android-device-name-mapping branch March 3, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants