feat: Add branch to use taskbroker-client#110001
Conversation
Add branches that let us opt-in to using taskbroker-client in deployments via environment variables. Refs STREAM-610
Fix type errors in sentry.taskworker, there are likely more.
use some cheatcodes to get around mypy
There are instanceof checks in the scheduler that we need to work around.
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| tags: Tags | None = None, | ||
| sample_rate: float | None = None, | ||
| ) -> None: | ||
| sentry_metrics.incr(name, amount=int(value), tags=tags, sample_rate=sample_rate or 1.0) |
There was a problem hiding this comment.
Falsy sample_rate of 0.0 silently becomes 1.0
Low Severity
The expression sample_rate or 1.0 uses Python's truthy evaluation, which means an explicit sample_rate=0.0 would be treated as falsy and silently replaced with 1.0. The correct check is sample_rate if sample_rate is not None else 1.0. This affects incr, distribution, and timer.
Additional Locations (2)
| app.load_modules() | ||
| run_storage = RunStorage(redis_clusters.get(redis_cluster)) | ||
| if settings.TASKWORKER_USE_LIBRARY: | ||
| from django.conf import settings |
There was a problem hiding this comment.
Redundant re-import of settings inside branch
Low Severity
from django.conf import settings is imported at line 143 (needed for the if settings.TASKWORKER_USE_LIBRARY check on line 145), then redundantly imported again at line 146 inside that same if block. The second import is dead code.
1 participant
Add branches that let us opt-in to using taskbroker-client in deployments via environment variables.
Refs STREAM-610