feat: Disable webhook forwarding to codecov#110023
Draft
calvin-codecov wants to merge 1 commit intomasterfrom
Draft
feat: Disable webhook forwarding to codecov#110023calvin-codecov wants to merge 1 commit intomasterfrom
calvin-codecov wants to merge 1 commit intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
Backend Test FailuresFailures on
|
Contributor
Backend Test FailuresFailures on
|
calvin-codecov
force-pushed
the
cy/disable_codecov_webhook_forward
branch
from
3695ac5 to
836969a
Compare
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| """ | ||
|
|
||
| if options.get("codecov.forward-webhooks.disabled"): | ||
| return True |
Contributor
There was a problem hiding this comment.
Same flag checked redundantly across call chain
Low Severity
The codecov.forward-webhooks.disabled option is checked at five locations across only two call chains. In the delivery path, perform_request → perform_codecov_request → _should_skip_codecov_forward_for_github_owner all check the same flag. In the parser path, try_forward_to_codecov → forward_to_codecov both check it. The check in _should_skip_codecov_forward_for_github_owner is especially misplaced since the function is semantically about owner-based filtering, not global disable. This redundancy increases maintenance burden — if the option key changes, five locations need updating.
Additional Locations (2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable webhook forwarding behind a flag.