chore(tests): replace store_trace_metrics with store_eap_items#110141
Open
chore(tests): replace store_trace_metrics with store_eap_items#110141
Conversation
github-actions
bot
added
the
Scope: Backend
Abdkhan14
approved these changes
Mar 6, 2026
store_trace_metrics is functionally identical to store_eap_items — both serialize protobuf TraceItems and POST them to the EAP items insert endpoint. The only difference was the multipart file key prefix (e.g. "trace_metric_0" vs "eap_items_0"), which Snuba ignores. Consolidating to a single helper reduces duplication in test utilities.
wedamija
force-pushed
the
danf/consolidate-store-trace-metrics
branch
from
006b5a7 to
de86ef3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
store_trace_metrics is functionally identical to store_eap_items — both serialize protobuf TraceItems and POST them to the EAP items insert endpoint. The only difference was the multipart file key prefix (e.g. "trace_metric_0" vs "eap_items_0"), which Snuba ignores.
Consolidating to a single helper reduces duplication in test utilities.