Skip to content

ref(cells): Remove no-longer-needed shims for getsentry#110170

Open
lynnagara wants to merge 5 commits intomasterfrom
cells-getsentry-shims
Open

ref(cells): Remove no-longer-needed shims for getsentry#110170
lynnagara wants to merge 5 commits intomasterfrom
cells-getsentry-shims

Conversation

@lynnagara
Copy link
Member

@lynnagara lynnagara commented Mar 6, 2026

these were part of the region_name -> cell_name migration and are no longer needed

switch all remaining callers of region_name to cell_name

depends on https://github.com/getsentry/getsentry/pull/19500 and https://github.com/getsentry/getsentry/pull/19503

these were part of the region_name -> cell_name migration and are no longer needed
@lynnagara lynnagara requested a review from a team as a code owner March 6, 2026 22:44
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 6, 2026
@lynnagara lynnagara requested a review from a team March 6, 2026 22:45
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@lynnagara lynnagara requested review from a team as code owners March 6, 2026 22:55
@lynnagara lynnagara requested review from logaretm and stephanie-anderson and removed request for a team March 6, 2026 22:55
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

Backend Test Failures

Failures on b1ac433 in this run:

tests/sentry/middleware/integrations/parsers/test_plugin.py::PluginRequestParserTest::test_routing_webhooks_with_regionlog
.venv/lib/python3.13/site-packages/django/db/models/options.py:683: in get_field
    return self.fields_map[field_name]
E   KeyError: 'region_name'

During handling of the above exception, another exception occurred:
tests/sentry/middleware/integrations/parsers/test_plugin.py:47: in test_routing_webhooks_with_region
    OrganizationMapping.objects.get(organization_id=self.organization.id).update(
src/sentry/silo/base.py:158: in override
    return original_method(*args, **kwargs)
src/sentry/db/models/query.py:92: in update
    instance.__class__.objects.using(using)
src/sentry/silo/base.py:158: in override
    return original_method(*args, **kwargs)
src/sentry/db/models/manager/base_query_set.py:92: in update
    return super().update(**kwargs)
.venv/lib/python3.13/site-packages/django/db/models/query.py:1237: in update
    query.add_update_values(kwargs)
.venv/lib/python3.13/site-packages/django/db/models/sql/subqueries.py:88: in add_update_values
    field = self.get_meta().get_field(name)
.venv/lib/python3.13/site-packages/django/db/models/options.py:685: in get_field
    raise FieldDoesNotExist(
E   django.core.exceptions.FieldDoesNotExist: OrganizationMapping has no field named 'region_name'
tests/sentry/synapse/endpoints/test_org_cell_mappings.py::OrgCellMappingsTest::test_get_results_no_nextlog
tests/sentry/synapse/endpoints/test_org_cell_mappings.py:71: in test_get_results_no_next
    assert res.status_code == 200
E   assert 500 == 200
E    +  where 500 = <Response status_code=500, "application/json">.status_code
tests/sentry/synapse/endpoints/test_org_cell_mappings.py::OrgCellMappingsTest::test_get_next_pagelog
tests/sentry/synapse/endpoints/test_org_cell_mappings.py:92: in test_get_next_page
    assert res.status_code == 200
E   assert 500 == 200
E    +  where 500 = <Response status_code=500, "application/json">.status_code
tests/sentry/middleware/integrations/parsers/test_bitbucket_server.py::BitbucketServerRequestParserTest::test_routing_webhooklog
.venv/lib/python3.13/site-packages/django/db/models/options.py:683: in get_field
    return self.fields_map[field_name]
E   KeyError: 'region_name'

During handling of the above exception, another exception occurred:
tests/sentry/middleware/integrations/parsers/test_bitbucket_server.py:37: in test_routing_webhook
    OrganizationMapping.objects.get(organization_id=self.organization.id).update(
src/sentry/silo/base.py:158: in override
    return original_method(*args, **kwargs)
src/sentry/db/models/query.py:92: in update
    instance.__class__.objects.using(using)
src/sentry/silo/base.py:158: in override
    return original_method(*args, **kwargs)
src/sentry/db/models/manager/base_query_set.py:92: in update
    return super().update(**kwargs)
.venv/lib/python3.13/site-packages/django/db/models/query.py:1237: in update
    query.add_update_values(kwargs)
.venv/lib/python3.13/site-packages/django/db/models/sql/subqueries.py:88: in add_update_values
    field = self.get_meta().get_field(name)
.venv/lib/python3.13/site-packages/django/db/models/options.py:685: in get_field
    raise FieldDoesNotExist(
E   django.core.exceptions.FieldDoesNotExist: OrganizationMapping has no field named 'region_name'
tests/sentry/synapse/endpoints/test_org_cell_mappings.py::OrgCellMappingsTest::test_get_locale_filterlog
tests/sentry/synapse/endpoints/test_org_cell_mappings.py:149: in test_get_locale_filter
    assert res.status_code == 200
E   assert 500 == 200
E    +  where 500 = <Response status_code=500, "application/json">.status_code
tests/sentry/api/endpoints/test_accept_organization_invite.py::AcceptInviteTest::test_multi_region_organizationmember_idlog
tests/sentry/api/endpoints/test_accept_organization_invite.py:159: in test_multi_region_organizationmember_id
    self.create_organization_mapping(
src/sentry/testutils/fixtures.py:666: in create_organization_mapping
    return Factories.create_org_mapping(*args, **kwargs)
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/contextlib.py:85: in inner
    return func(*args, **kwds)
src/sentry/testutils/factories.py:434: in create_org_mapping
    return OrganizationMapping.objects.create(**kwds)
src/sentry/silo/base.py:158: in override
    return original_method(*args, **kwargs)
.venv/lib/python3.13/site-packages/django/db/models/manager.py:87: in manager_method
    return getattr(self.get_queryset(), name)(*args, **kwargs)
src/sentry/silo/base.py:158: in override
    return original_method(*args, **kwargs)
.venv/lib/python3.13/site-packages/django/db/models/query.py:663: in create
    obj = self.model(**kwargs)
.venv/lib/python3.13/site-packages/django/db/models/base.py:569: in __init__
    raise TypeError(
E   TypeError: OrganizationMapping() got unexpected keyword arguments: 'region_name'
tests/sentry/hybridcloud/test_rpc.py::RpcServiceTest::test_remote_servicelog
tests/sentry/hybridcloud/test_rpc.py:68: in test_remote_service
    service.add_organization_member(
src/sentry/hybridcloud/rpc/service.py:346: in remote_method
    result = signature.resolve_to_region(kwargs)
src/sentry/hybridcloud/rpc/service.py:119: in resolve_to_region
    region = self._region_resolution.resolve(arguments)
src/sentry/hybridcloud/rpc/resolvers.py:66: in resolve
    return self._get_from_mapping(organization_id=organization_id)
src/sentry/hybridcloud/rpc/resolvers.py:35: in _get_from_mapping
    return get_cell_by_name(mapping.cell_name)
src/sentry/types/region.py:331: in get_cell_by_name
    raise RegionResolutionError(
E   sentry.types.region.RegionResolutionError: No cell with name: 'testregion467840' (expected one of ['north_america', 'europe'] or a single-tenant name)
tests/sentry/middleware/integrations/parsers/test_bitbucket.py::BitbucketRequestParserTest::test_routing_webhook_no_regionslog
.venv/lib/python3.13/site-packages/django/db/models/options.py:683: in get_field
    return self.fields_map[field_name]
E   KeyError: 'region_name'

During handling of the above exception, another exception occurred:
tests/sentry/middleware/integrations/parsers/test_bitbucket.py:69: in test_routing_webhook_no_regions
    OrganizationMapping.objects.get(organization_id=self.organization.id).update(
src/sentry/silo/base.py:158: in override
    return original_method(*args, **kwargs)
src/sentry/db/models/query.py:92: in update
    instance.__class__.objects.using(using)
src/sentry/silo/base.py:158: in override
    return original_method(*args, **kwargs)
src/sentry/db/models/manager/base_query_set.py:92: in update
    return super().update(**kwargs)
.venv/lib/python3.13/site-packages/django/db/models/query.py:1237: in update
    query.add_update_values(kwargs)
.venv/lib/python3.13/site-packages/django/db/models/sql/subqueries.py:88: in add_update_values
    field = self.get_meta().get_field(name)
.venv/lib/python3.13/site-packages/django/db/models/options.py:685: in get_field
    raise FieldDoesNotExist(
E   django.core.exceptions.FieldDoesNotExist: OrganizationMapping has no field named 'region_name'
tests/sentry/middleware/integrations/parsers/test_plugin.py::PluginRequestParserTest::test_routing_webhooks_no_regionlog
.venv/lib/python3.13/site-packages/django/db/models/options.py:683: in get_field
    return self.fields_map[field_name]
E   KeyError: 'region_name'

During handling of the above exception, another exception occurred:
tests/sentry/middleware/integrations/parsers/test_plugin.py:28: in test_routing_webhooks_no_region
    OrganizationMapping.objects.get(organization_id=self.organization.id).update(
src/sentry/silo/base.py:158: in override
    return original_method(*args, **kwargs)
src/sentry/db/models/query.py:92: in update
    instance.__class__.objects.using(using)
src/sentry/silo/base.py:158: in override
    return original_method(*args, **kwargs)
src/sentry/db/models/manager/base_query_set.py:92: in update
    return super().update(**kwargs)
.venv/lib/python3.13/site-packages/django/db/models/query.py:1237: in update
    query.add_update_values(kwargs)
.venv/lib/python3.13/site-packages/django/db/models/sql/subqueries.py:88: in add_update_values
    field = self.get_meta().get_field(name)
.venv/lib/python3.13/site-packages/django/db/models/options.py:685: in get_field
    raise FieldDoesNotExist(
E   django.core.exceptions.FieldDoesNotExist: OrganizationMapping has no field named 'region_name'
tests/sentry/synapse/endpoints/test_org_cell_mappings.py::OrgCellMappingsTest::test_get_multiple_pages_multiple_localeslog
tests/sentry/synapse/endpoints/test_org_cell_mappings.py:113: in test_get_multiple_pages_multiple_locales
    assert res.status_code == 200
E   assert 500 == 200
E    +  where 500 = <Response status_code=500, "application/json">.status_code

@lynnagara
Copy link
Member Author

needs https://github.com/getsentry/getsentry/pull/19503 first for the getsentry tests to pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants