Skip to content

ref(issues): Use module logger in issue_occurrence #114646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mrduncan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ref(issues): Use module logger in issue_occurrence #114646

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/sentry/issues/issue_occurrence.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
from sentry.types.actor import Actor
from sentry.utils.dates import parse_timestamp

logger = logging.getLogger(__name__)

DEFAULT_LEVEL = "info"


Expand Down Expand Up @@ -147,10 +149,10 @@ def from_dict(cls, data: IssueOccurrenceData) -> IssueOccurrence:
# that, so subsequent fetches won't cause IO.
assignee = Actor.from_identifier(data.get("assignee"))
except ValidationError:
logging.exception("Failed to parse assignee actor identifier")
logger.exception("Failed to parse assignee actor identifier")
except Exception:
# We never want this to cause parsing an occurrence to fail
logging.exception("Unexpected error parsing assignee")
logger.exception("Unexpected error parsing assignee")
return cls(
data["id"],
data["project_id"],
Expand Down
Loading