fix(sync_repos): Handle string JSON in VSTS and error dicts in GitLab#114656
Open
fix(sync_repos): Handle string JSON in VSTS and error dicts in GitLab#114656
Conversation
Guard against non-dict exc.json in message_from_error and validate that GitLab search_projects returns project dicts, not error keys. Fixes SENTRY-5NAY Fixes SENTRY-5NBH Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
Comment on lines
+530
to
533
| if exc.json and isinstance(exc.json, dict): | ||
| msg = self.error_message_from_json(exc.json) or "unknown error" | ||
| else: | ||
| msg = "unknown error" |
Contributor
There was a problem hiding this comment.
Bug: The raise_error method may cause an AttributeError by passing a non-dictionary exc.json to error_fields_from_json, which expects a dictionary.
Severity: MEDIUM
Suggested Fix
In the raise_error method, add a check to ensure exc.json is a dictionary before passing it to self.error_fields_from_json. For example: if exc.json and isinstance(exc.json, dict):.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: src/sentry/integrations/base.py#L530-L533
Potential issue: The `raise_error` method calls `self.error_fields_from_json(exc.json)`
if `exc.json` is truthy, but it does not validate that `exc.json` is a dictionary.
Subclasses like `JiraIntegration` and `JiraServerIntegration` implement
`error_fields_from_json` by calling the `.get()` method on the input, assuming it is a
dictionary. If an API returns a non-dictionary JSON response, such as a string,
`exc.json` will be a truthy string. This will cause an `AttributeError` when `.get()` is
called, crashing the integration's error handling logic.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guard against non-dict exc.json in message_from_error and validate that GitLab search_projects returns project dicts, not error keys.
Fixes SENTRY-5NAY
Fixes SENTRY-5NBH