Drop forceUpdate from TimeSince; use state/props changes instead #2203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
doesnt this mean 1s doesnt update until its 61s?
There was a problem hiding this comment.
Yeah, that's true (it was doing that before, too, except every 43 secs).
We should make the timeout according to the duration of the relative time. Follow-up?
There was a problem hiding this comment.
yeah i guess thats true, dont know why it was 2600
There was a problem hiding this comment.
I kind of just assumed it was a mistake and 3600 was intended.
|
Before:
After:
(Note these charts don't incorporate bar chart perf improvements from #2202. |
benvinegar
force-pushed
the
react-0.14
branch
from
c45c365 to
f2a7131
Compare
benvinegar
force-pushed
the
fast-timesince
branch
from
d4287eb to
aef692c
Compare
|
Closing because wrong target. See #2207. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves performance of
TimeSincecomponent by removing theforceUpdatecall we were using to trigger relative time updates.Now we update relative time via
state.relative– React handles the rest.Makes a noticeable difference on the stream view, where rendering goes from ~25ms on 25 stream items down to ~2ms.
Note this is targeted against the react-0.14 branch.