Skip to content

Drop forceUpdate from TimeSince; use state/props changes instead #2207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2015
Merged

Drop forceUpdate from TimeSince; use state/props changes instead #2207

merged 1 commit into from
Oct 19, 2015

Conversation

benvinegar
Copy link
Contributor

See #2203

@codecov-io
Copy link

Current coverage is 74.70%

Merging #2207 into master will decrease coverage by -0.09% as of d4287eb

@@            master   #2207   diff @@
======================================
  Files          527     527       
  Stmts        20709   20654    -55
  Branches         0       0       
  Methods          0       0       
======================================
- Hit          15490   15430    -60
  Partial          0       0       
- Missed        5219    5224     +5

Review entire Coverage Diff as of d4287eb

Uncovered Suggestions

  1. +0.11% via ...try/utils/apidocs.py#410...432
  2. +0.11% via ...try/utils/apidocs.py#117...139
  3. +0.10% via ...gs/sentry_helpers.py#182...202
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@benvinegar benvinegar mentioned this pull request Oct 19, 2015
Closed
benvinegar added a commit that referenced this pull request Oct 19, 2015
@benvinegar
Merge pull request #2207 from getsentry/fast-timesince
e5beabd 
Drop forceUpdate from TimeSince; use state/props changes instead
@benvinegar benvinegar merged commit e5beabd into master Oct 19, 2015
@dcramer dcramer deleted the fast-timesince branch November 20, 2015 21:37
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benvinegar @codecov-io