feat(custom-views): Add hook for fetching issue counts#76277
Closed
MichaelSun48 wants to merge 4844 commits intomasterfrom
Closed
feat(custom-views): Add hook for fetching issue counts#76277MichaelSun48 wants to merge 4844 commits intomasterfrom
MichaelSun48 wants to merge 4844 commits intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Frontend
malwilley
reviewed
Aug 15, 2024
malwilley
approved these changes
Aug 15, 2024
Contributor
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
- Don't allow full screen in error state - Show actions in error mode if there is no retry - Add error boundary
This switches explore to use the RPC layer to make queries by default behind a feature flag.
… hydration issue modal (#82779) These links will accept clicks now: <img width="559" alt="SCR-20241231-kcqh" src="https://github.com/user-attachments/assets/4f3e4ec3-0033-4ced-8c53-dbfdcf445af6" /> Fixes #82776
Currently, if a specific web vital is never reported in a query, we treat the score as 0. This is actually misleading, instead we want to exclude missing vitals from any score calculation. This flag will control the logic in the frontend and backend to handle that.
<!-- Describe your PR here. -->
I only got through about ~30% of the test files -- will follow up with other ones some explanation for some patterns: - deleted function => nothing called it - `raise SomeType` -> `raise AssertionError` -- `AssertionError` is excluded from coverage - `pass` -> `raise NotImplementedError` -- these functions are never called -- only used for their shape / name and `NotImplementedError` is excluded from coverage - `try: some_test_code except: fail(...)` -> no need for the `try`, an uncaught exception already fails the test <!-- Describe your PR here. -->
…2797) remove `members-invite-teammates` feature flag from frontend
This allows us to measure the stability of devservices for sentry backend tests. Changing the cadence of this scheduled job to hourly again, as we need more data here. Will check devinfra metrics to get a better sense of how well this is working in CI
MichaelSun48
requested review from
AbhiPrasad and
lforst
and removed request for
a team
github-actions
bot
added
the
Scope: Backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a useAPIQuery hook for the
organization/.../issues-countendpoint. This is going to be used by the custom views component to fetch the query counts for new tabs.Update 1/6: We've decided to re-add this functionality, which is why this PR has been reopened