fix(instrumentation): Fix false double leading slashes in transaction names

[gggritso]

See comment in details. Prevents errors and transaction events with names like "//dashboards/:dashboardId" caused by a bad interaction between React Router 6 instrumentation in the SDK and our shimming setup.

I'm not sure if other kinds of telemetry (Profiles, Replays, breadcrumbs) also need a fix, but it didn't seem like it.

[codecov]

❌ 7 Tests Failed:

Tests completed	Failed	Passed	Skipped
8438	7	8431	0

View the top 3 failed tests by shortest run time

WidgetBuilder Events Widgets Custom Performance Metrics can choose a custom measurement

Stack Traces | 3.07s run time

TypeError: Cannot read properties of null (reading 'parentNode')
    at getReactSelectContainerFromInput (.../js/sentry-test/selectEvent.tsx:39:38)
    at Object.select (.../js/sentry-test/selectEvent.tsx:99:19)
    at Object.<anonymous> (.../dashboards/widgetBuilder/widgetBuilderDataset.spec.tsx:704:9)

InviteRowControlNew updates email addresses when new emails are inputted invokes the mock correctly with many using delimiter ","

Stack Traces | 5.02s run time

Error: thrown: "Exceeded timeout of 5000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."
    at .../modals/inviteMembersModal/inviteRowControlNew.spec.tsx:80:5
    at .../jest-each/build/bind.js:81:13
    at _dispatchDescribe (.../jest-circus/build/index.js:91:26)
    at describe (.../jest-circus/build/index.js:55:5)
    at .../jest-each/build/bind.js:47:15
    at Array.forEach (<anonymous>)
    at eachBind (.../jest-each/build/bind.js:39:22)
    at .../modals/inviteMembersModal/inviteRowControlNew.spec.tsx:64:6
    at _dispatchDescribe (.../jest-circus/build/index.js:91:26)
    at describe (.../jest-circus/build/index.js:55:5)
    at Object.<anonymous> (.../modals/inviteMembersModal/inviteRowControlNew.spec.tsx:10:1)
    at Runtime._execModule (.../jest-runtime/build/index.js:1439:24)
    at Runtime._loadModule (.../jest-runtime/build/index.js:1022:12)
    at Runtime.requireModule (.../jest-runtime/build/index.js:882:12)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:77:13)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)

InviteRowControlNew updates email addresses when new emails are inputted invokes the mock correctly with many using delimiter "{enter}"

Stack Traces | 5.04s run time

Error: thrown: "Exceeded timeout of 5000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."
    at .../modals/inviteMembersModal/inviteRowControlNew.spec.tsx:80:5
    at .../jest-each/build/bind.js:81:13
    at _dispatchDescribe (.../jest-circus/build/index.js:91:26)
    at describe (.../jest-circus/build/index.js:55:5)
    at .../jest-each/build/bind.js:47:15
    at Array.forEach (<anonymous>)
    at eachBind (.../jest-each/build/bind.js:39:22)
    at .../modals/inviteMembersModal/inviteRowControlNew.spec.tsx:64:6
    at _dispatchDescribe (.../jest-circus/build/index.js:91:26)
    at describe (.../jest-circus/build/index.js:55:5)
    at Object.<anonymous> (.../modals/inviteMembersModal/inviteRowControlNew.spec.tsx:10:1)
    at Runtime._execModule (.../jest-runtime/build/index.js:1439:24)
    at Runtime._loadModule (.../jest-runtime/build/index.js:1022:12)
    at Runtime.requireModule (.../jest-runtime/build/index.js:882:12)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:77:13)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

[malwilley]

This PR should fix this for real: getsentry/sentry-javascript#14821

But this seems like a good interim fix

[gggritso]

@malwilley oh nice, I didn't see that! Since that PR's the proper fix, and this has already been broken for an eternity, I don't think this interim fix is really worthwhile, I'm just gonna close it 👍🏻