Skip to content

fix: add os.distribution_X FieldKey values to autofill search #81656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2024
Merged

fix: add os.distribution_X FieldKey values to autofill search #81656

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions static/app/utils/fields/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,8 @@ export enum FieldKey {
OS_BUILD = 'os.build',
OS_KERNEL_VERSION = 'os.kernel_version',
OS_NAME = 'os.name',
OS_DISTRIBUTION_NAME = 'os.distribution_name',
OS_DISTRIBUTION_VERSION = 'os.distribution_version',
PLATFORM = 'platform',
PLATFORM_NAME = 'platform.name',
PROFILE_ID = 'profile.id',
Expand Down Expand Up @@ -1523,6 +1525,16 @@ const EVENT_FIELD_DEFINITIONS: Record<AllEventFieldKeys, FieldDefinition> = {
kind: FieldKind.FIELD,
valueType: FieldValueType.STRING,
},
[FieldKey.OS_DISTRIBUTION_NAME]: {
desc: t('Distribution name'),
kind: FieldKind.FIELD,
valueType: FieldValueType.STRING,
},
[FieldKey.OS_DISTRIBUTION_VERSION]: {
desc: t('Distribution version number'),
kind: FieldKind.FIELD,
valueType: FieldValueType.STRING,
},
[FieldKey.PLATFORM]: {
desc: t('Name of the platform'),
kind: FieldKind.FIELD,
Expand Down Expand Up @@ -1837,6 +1849,8 @@ export const ISSUE_EVENT_PROPERTY_FIELDS: FieldKey[] = [
FieldKey.MESSAGE,
FieldKey.OS_BUILD,
FieldKey.OS_KERNEL_VERSION,
FieldKey.OS_DISTRIBUTION_NAME,
FieldKey.OS_DISTRIBUTION_VERSION,
FieldKey.PLATFORM_NAME,
FieldKey.RELEASE_BUILD,
FieldKey.RELEASE_PACKAGE,
Expand Down Expand Up @@ -1905,6 +1919,8 @@ export const ISSUE_EVENT_FIELDS_THAT_MAY_CONFLICT_WITH_TAGS: Set<FieldKey> = new
FieldKey.MESSAGE,
FieldKey.OS_BUILD,
FieldKey.OS_KERNEL_VERSION,
FieldKey.OS_DISTRIBUTION_NAME,
FieldKey.OS_DISTRIBUTION_VERSION,
Comment on lines +1922 to +1923
Copy link
Member Author

@JoshuaMoelans JoshuaMoelans Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if they conflict with tags, but put them in here as well since the OS_KERNEL_VERSION is here too.

FieldKey.PLATFORM_NAME,
FieldKey.RELEASE_BUILD,
FieldKey.RELEASE_PACKAGE,
Expand Down Expand Up @@ -1967,6 +1983,8 @@ export const DISCOVER_FIELDS = [
FieldKey.HTTP_URL,
FieldKey.OS_BUILD,
FieldKey.OS_KERNEL_VERSION,
FieldKey.OS_DISTRIBUTION_NAME,
FieldKey.OS_DISTRIBUTION_VERSION,
FieldKey.DEVICE_NAME,
FieldKey.DEVICE_BRAND,
FieldKey.DEVICE_LOCALE,
Expand Down
Loading