Skip to content

Conversation

@enochtangg
Copy link
Contributor

Now that taskbroker gRPC supports getting tasks by namespace, this PR enables the taskworker to use that parameter if provided.

Depends on: getsentry/taskbroker#74

@enochtangg enochtangg requested a review from a team December 9, 2024 16:52
@enochtangg enochtangg requested a review from a team as a code owner December 9, 2024 16:52
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Dec 9, 2024
@enochtangg enochtangg self-assigned this Dec 9, 2024
@enochtangg enochtangg changed the title feat(taskworker): Add namespace parameter to get task client feat(taskworker): Add namespace parameter to taskworker client Dec 9, 2024
@codecov
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #81860   +/-   ##
=======================================
  Coverage   80.33%   80.34%           
=======================================
  Files        7260     7264    +4     
  Lines      320854   320907   +53     
  Branches    20880    20880           
=======================================
+ Hits       257766   257819   +53     
  Misses      62693    62693           
  Partials      395      395           

@enochtangg enochtangg merged commit e8f21d4 into master Dec 10, 2024
51 checks passed
@enochtangg enochtangg deleted the get-task-by-namespace branch December 10, 2024 16:13
mifu67 pushed a commit that referenced this pull request Dec 10, 2024
Now that taskbroker gRPC supports getting tasks by namespace, this PR
enables the taskworker to use that parameter if provided.


Depends on: getsentry/taskbroker#74
@github-actions github-actions bot locked and limited conversation to collaborators Dec 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants