Skip to content

profiling: update profiling onboarding to use new API #86986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 21, 2025
Merged

profiling: update profiling onboarding to use new API #86986

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fa33c7a
profiling: update continuous profilin onboarding to use new method
JonasBa Mar 13, 2025
341ba10
profiling: update continuous profilin onboarding to use new method
JonasBa Mar 13, 2025
8adbd6a
profiling: update continuous profilin onboarding to use new method
JonasBa Mar 13, 2025
9544979
profiling: update comments
JonasBa Mar 13, 2025
6452193
add profileSessionSampleRate
JonasBa Mar 13, 2025
2c334ff
Merge branch 'master' into jb/docs/continuous-profiling-node
JonasBa Mar 13, 2025
36a1d91
update to latest change
JonasBa Mar 21, 2025
ce273d3
Merge branch 'master' into jb/docs/continuous-profiling-node
JonasBa Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions static/app/gettingStartedDocs/node/awslambda.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,10 @@ describe('awslambda onboarding docs', function () {

// Should have start and stop profiling calls
expect(
screen.getByText(textWithMarkupMatcher(/Sentry.profiler.startProfiler/))
screen.getByText(textWithMarkupMatcher(/Sentry.profiler.startProfileSession/))
).toBeInTheDocument();
expect(
screen.getByText(textWithMarkupMatcher(/Sentry.profiler.stopProfiler/))
screen.getByText(textWithMarkupMatcher(/Sentry.profiler.stopProfileSession/))
).toBeInTheDocument();
});
});
4 changes: 2 additions & 2 deletions static/app/gettingStartedDocs/node/azurefunctions.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,10 @@ describe('express onboarding docs', function () {

// Should have start and stop profiling calls
expect(
screen.getByText(textWithMarkupMatcher(/Sentry.profiler.startProfiler/))
screen.getByText(textWithMarkupMatcher(/Sentry.profiler.startProfileSession/))
).toBeInTheDocument();
expect(
screen.getByText(textWithMarkupMatcher(/Sentry.profiler.stopProfiler/))
screen.getByText(textWithMarkupMatcher(/Sentry.profiler.stopProfileSession/))
).toBeInTheDocument();
});
});
4 changes: 2 additions & 2 deletions static/app/gettingStartedDocs/node/connect.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,10 +109,10 @@ describe('connect onboarding docs', function () {

// Should have start and stop profiling calls
expect(
screen.getByText(textWithMarkupMatcher(/Sentry.profiler.startProfiler/))
screen.getByText(textWithMarkupMatcher(/Sentry.profiler.startProfileSession/))
).toBeInTheDocument();
expect(
screen.getByText(textWithMarkupMatcher(/Sentry.profiler.stopProfiler/))
screen.getByText(textWithMarkupMatcher(/Sentry.profiler.stopProfileSession/))
).toBeInTheDocument();
});
});
4 changes: 2 additions & 2 deletions static/app/gettingStartedDocs/node/express.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,10 +109,10 @@ describe('express onboarding docs', function () {

// Should have start and stop profiling calls
expect(
screen.getByText(textWithMarkupMatcher(/Sentry.profiler.startProfiler/))
screen.getByText(textWithMarkupMatcher(/Sentry.profiler.startProfileSession/))
).toBeInTheDocument();
expect(
screen.getByText(textWithMarkupMatcher(/Sentry.profiler.stopProfiler/))
screen.getByText(textWithMarkupMatcher(/Sentry.profiler.stopProfileSession/))
).toBeInTheDocument();
});
});
4 changes: 2 additions & 2 deletions static/app/gettingStartedDocs/node/fastify.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,10 +110,10 @@ describe('fastify onboarding docs', function () {

// Should have start and stop profiling calls
expect(
screen.getByText(textWithMarkupMatcher(/Sentry.profiler.startProfiler/))
screen.getByText(textWithMarkupMatcher(/Sentry.profiler.startProfileSession/))
).toBeInTheDocument();
expect(
screen.getByText(textWithMarkupMatcher(/Sentry.profiler.stopProfiler/))
screen.getByText(textWithMarkupMatcher(/Sentry.profiler.stopProfileSession/))
).toBeInTheDocument();
});
});
4 changes: 2 additions & 2 deletions static/app/gettingStartedDocs/node/gcpfunctions.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,10 +104,10 @@ describe('gcpfunctions onboarding docs', function () {

// Should have start and stop profiling calls
expect(
screen.getByText(textWithMarkupMatcher(/Sentry.profiler.startProfiler/))
screen.getByText(textWithMarkupMatcher(/Sentry.profiler.startProfileSession/))
).toBeInTheDocument();
expect(
screen.getByText(textWithMarkupMatcher(/Sentry.profiler.stopProfiler/))
screen.getByText(textWithMarkupMatcher(/Sentry.profiler.stopProfileSession/))
).toBeInTheDocument();
});
});
4 changes: 2 additions & 2 deletions static/app/gettingStartedDocs/node/hapi.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,10 +110,10 @@ describe('hapi onboarding docs', function () {

// Should have start and stop profiling calls
expect(
screen.getByText(textWithMarkupMatcher(/Sentry.profiler.startProfiler/))
screen.getByText(textWithMarkupMatcher(/Sentry.profiler.startProfileSession/))
).toBeInTheDocument();
expect(
screen.getByText(textWithMarkupMatcher(/Sentry.profiler.stopProfiler/))
screen.getByText(textWithMarkupMatcher(/Sentry.profiler.stopProfileSession/))
).toBeInTheDocument();
});
});
4 changes: 2 additions & 2 deletions static/app/gettingStartedDocs/node/koa.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,10 +110,10 @@ describe('koa onboarding docs', function () {

// Should have start and stop profiling calls
expect(
screen.getByText(textWithMarkupMatcher(/Sentry.profiler.startProfiler/))
screen.getByText(textWithMarkupMatcher(/Sentry.profiler.startProfileSession/))
).toBeInTheDocument();
expect(
screen.getByText(textWithMarkupMatcher(/Sentry.profiler.stopProfiler/))
screen.getByText(textWithMarkupMatcher(/Sentry.profiler.stopProfileSession/))
).toBeInTheDocument();
});
});
4 changes: 2 additions & 2 deletions static/app/gettingStartedDocs/node/nestjs.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,10 +110,10 @@ describe('Nest.js onboarding docs', function () {

// Should have start and stop profiling calls
expect(
screen.getByText(textWithMarkupMatcher(/Sentry.profiler.startProfiler/))
screen.getByText(textWithMarkupMatcher(/Sentry.profiler.startProfileSession/))
).toBeInTheDocument();
expect(
screen.getByText(textWithMarkupMatcher(/Sentry.profiler.stopProfiler/))
screen.getByText(textWithMarkupMatcher(/Sentry.profiler.stopProfileSession/))
).toBeInTheDocument();
});
});
4 changes: 2 additions & 2 deletions static/app/gettingStartedDocs/node/node.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,10 @@ describe('node onboarding docs', function () {

// Should have start and stop profiling calls
expect(
screen.getByText(textWithMarkupMatcher(/Sentry.profiler.startProfiler/))
screen.getByText(textWithMarkupMatcher(/Sentry.profiler.startProfileSession/))
).toBeInTheDocument();
expect(
screen.getByText(textWithMarkupMatcher(/Sentry.profiler.stopProfiler/))
screen.getByText(textWithMarkupMatcher(/Sentry.profiler.stopProfileSession/))
).toBeInTheDocument();
});
});
4 changes: 2 additions & 2 deletions static/app/utils/gettingStartedDocs/node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ Sentry.init({
? `
// Manually call startProfiler and stopProfiler
// to profile the code in between
Sentry.profiler.startProfiler();
Sentry.profiler.startProfileSession();
${
params.isPerformanceSelected
? `
Expand All @@ -243,7 +243,7 @@ Sentry.startSpan({
}
// Calls to stopProfiling are optional - if you don't stop the profiler, it will keep profiling
// your application until the process exits or stopProfiling is called.
Sentry.profiler.stopProfiler();`
Sentry.profiler.stopProfileSession();`
: ''
}`;

Expand Down
Loading