Skip to content

Conversation

@asottile-sentry
Copy link
Contributor

@asottile-sentry asottile-sentry requested review from a team April 21, 2025 19:16
@asottile-sentry asottile-sentry requested review from a team as code owners April 21, 2025 19:16
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 21, 2025
@codecov
Copy link

codecov bot commented Apr 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #90000       +/-   ##
===========================================
+ Coverage   46.28%   87.72%   +41.44%     
===========================================
  Files       10224    10239       +15     
  Lines      576639   577373      +734     
  Branches    22696    22696               
===========================================
+ Hits       266873   506522   +239649     
+ Misses     309323    70408   -238915     
  Partials      443      443               

Copy link
Member

@joshuarli joshuarli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hot damn!

@asottile-sentry asottile-sentry enabled auto-merge (squash) April 22, 2025 18:48
@asottile-sentry asottile-sentry force-pushed the asottile-auto-type-issues branch from b1eb163 to 91dce7b Compare April 22, 2025 18:48
@asottile-sentry asottile-sentry merged commit 1b74829 into master Apr 22, 2025
63 checks passed
@asottile-sentry asottile-sentry deleted the asottile-auto-type-issues branch April 22, 2025 19:07
andrewshie-sentry pushed a commit that referenced this pull request Apr 22, 2025
first commit automated via
https://github.com/getsentry/auto-type-annotate

- I used these patches to mypy:
    - python/mypy#18948
- (the line mentioned in the issue commented out):
python/mypy#18940 (comment)
- and with this unreverted (coming soon!):
#89854

<!-- Describe your PR here. -->
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants