Skip to content

feat(detectors): Update detection algorithm for MN+1 Experimental Detector #97533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

roggenkemper
Copy link
Member

this pr makes a few changes to the MN+1 Experimental Detector:

  1. it updates the _equivalent method to differentiate between spans that have the "default" op , which is common in Prisma. This made some detected issues be slightly off because it was finding a "pattern" with two spans that weren't necessarily the same
  2. It updates the definition of a valid pattern to exclude those that start with a serialization span. serialization spans come after a query or operation, so it doesn't make sense to start on them
  3. it keeps more of the most recent spans when leaving the continuing state which should allow for more accurate pattern finding.
    these changes should give more accurate results and fix issues we saw where the pattern was starting/ending 1-2 spans from where we expected it.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 8, 2025

This comment was marked as outdated.

@roggenkemper roggenkemper marked this pull request as ready for review August 12, 2025 16:54
@roggenkemper roggenkemper requested a review from a team as a code owner August 12, 2025 16:54
Copy link
Contributor

@cvxluo cvxluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants