feat(detectors): Update detection algorithm for MN+1 Experimental Detector #97533
+288
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
This comment was marked as outdated.
This comment was marked as outdated.
leeandher
approved these changes
Aug 15, 2025
priscilawebdev
pushed a commit
that referenced
this pull request
Aug 25, 2025
…ector (#97533) this pr makes a few changes to the MN+1 Experimental Detector: 1) it updates the `_equivalent` method to differentiate between spans that have the "default" op , which is common in Prisma. This made some detected issues be slightly off because it was finding a "pattern" with two spans that weren't necessarily the same 2) It updates the definition of a valid pattern to exclude those that start with a serialization span. serialization spans come after a query or operation, so it doesn't make sense to start on them 3) it keeps more of the most recent spans when leaving the continuing state which should allow for more accurate pattern finding. these changes should give more accurate results and fix issues we saw where the pattern was starting/ending 1-2 spans from where we expected it.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Aug 26, 2025
…ector (#97533) this pr makes a few changes to the MN+1 Experimental Detector: 1) it updates the `_equivalent` method to differentiate between spans that have the "default" op , which is common in Prisma. This made some detected issues be slightly off because it was finding a "pattern" with two spans that weren't necessarily the same 2) It updates the definition of a valid pattern to exclude those that start with a serialization span. serialization spans come after a query or operation, so it doesn't make sense to start on them 3) it keeps more of the most recent spans when leaving the continuing state which should allow for more accurate pattern finding. these changes should give more accurate results and fix issues we saw where the pattern was starting/ending 1-2 spans from where we expected it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr makes a few changes to the MN+1 Experimental Detector:
_equivalentmethod to differentiate between spans that have the "default" op , which is common in Prisma. This made some detected issues be slightly off because it was finding a "pattern" with two spans that weren't necessarily the samethese changes should give more accurate results and fix issues we saw where the pattern was starting/ending 1-2 spans from where we expected it.