Skip to content

ref(autofix): Reuse the organization trace endpoint to simplify logic #97550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 11, 2025

Conversation

roaga
Copy link
Member

@roaga roaga commented Aug 9, 2025

The tracing logic didn't seem to be working quite right, and it was super complex and unmaintainable anyway to try to mold it into the old transaction-based logic.

So this PR simplifies things by just reusing the OrganizationTraceEndpoint, similar to the AI trace summary endpoint. On the Seer side, we'll also need to make changes to support the new data structure.

Seer PR: https://github.com/getsentry/seer/pull/3117

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Aug 9, 2025
Copy link

codecov bot commented Aug 9, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 7 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/seer/autofix/autofix.py 83.33% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #97550      +/-   ##
==========================================
- Coverage   80.73%   80.61%   -0.12%     
==========================================
  Files        8566     8560       -6     
  Lines      378963   376939    -2024     
  Branches    24538    24538              
==========================================
- Hits       305948   303881    -2067     
- Misses      72645    72688      +43     
  Partials      370      370              

@roaga roaga marked this pull request as ready for review August 11, 2025 14:15
@roaga roaga requested a review from a team as a code owner August 11, 2025 14:15
@roaga roaga requested a review from kddubey August 11, 2025 14:15
@roaga roaga merged commit 75bca5b into master Aug 11, 2025
64 checks passed
@roaga roaga deleted the autofix/reuse-trace-endpoint branch August 11, 2025 20:34
Copy link

sentry-io bot commented Aug 11, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎

andrewshie-sentry pushed a commit that referenced this pull request Aug 12, 2025
…#97550)

The tracing logic didn't seem to be working quite right, and it was
super complex and unmaintainable anyway to try to mold it into the old
transaction-based logic.

So this PR simplifies things by just reusing the
OrganizationTraceEndpoint, similar to the AI trace summary endpoint. On
the Seer side, we'll also need to make changes to support the new data
structure.

Seer PR: getsentry/seer#3117

---------

Co-authored-by: Kush Dubey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants