chore(launchpad): Return created instead of OK upon chunks being successfully uploaded #97559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essfully uploaded
github-actions
bot
added
the
Scope: Backend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #97559 +/- ##
==========================================
- Coverage 80.73% 80.62% -0.11%
==========================================
Files 8566 8560 -6
Lines 378963 376889 -2074
Branches 24538 24538
==========================================
- Hits 305948 303867 -2081
- Misses 72645 72652 +7
Partials 370 370 |
|
actually just going to merge this into #97558 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A request made by @szokeasaurusrex so that we're more idiomatically correct even though we aren't ultimately going to return "OK" state anymore. This will be landed after we land a change to the CLI to be satisfied by the endpoint when it receives "CREATED" instead of "OK" (current functionality).