feat(aci): Write to IncidentGroupOpenPeriod #97621
Merged
+560
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
|
PR reverted: 252a381 |
getsentry-bot
added a commit
that referenced
this pull request
Aug 12, 2025
This reverts commit 433839b. Co-authored-by: ceorourke <[email protected]>
ceorourke
added a commit
that referenced
this pull request
Aug 12, 2025
3rd attempt at this PR - I merged #97621 but somehow hit a [circular import issue](https://github.com/getsentry/getsentry/actions/runs/16916645085/job/47932103426) that CI didn't catch. I've rebased after fixing the import issue. --------- Co-authored-by: Snigdha Sharma <[email protected]>
andrewshie-sentry
pushed a commit
that referenced
this pull request
Aug 12, 2025
Redo of #96221 after [adding an index](#97534) to the `GroupOpenPeriod`'s `data` column on `pending_incident_detector_id` which should hopefully not result in [the error](https://sentry.sentry.io/issues/6799376702/) anymore. There are no changes to this PR from the original one. --------- Co-authored-by: Snigdha Sharma <[email protected]>
andrewshie-sentry
pushed a commit
that referenced
this pull request
Aug 12, 2025
This reverts commit 433839b. Co-authored-by: ceorourke <[email protected]>
andrewshie-sentry
pushed a commit
that referenced
this pull request
Aug 12, 2025
3rd attempt at this PR - I merged #97621 but somehow hit a [circular import issue](https://github.com/getsentry/getsentry/actions/runs/16916645085/job/47932103426) that CI didn't catch. I've rebased after fixing the import issue. --------- Co-authored-by: Snigdha Sharma <[email protected]>
ceorourke
added a commit
that referenced
this pull request
Aug 14, 2025
…low engine (#95487) Duplicate tests from `subscription_processor.py` but rewritten for workflow engine. These will be used for single processing to ensure we don't lose test coverage. This has a lot of tests but isn't comprehensive, there will be follow up PRs for: * Anomaly detection tests * Adding `assert_open_period` and `assert_no_open_period` methods and adding those to tests (waiting on #97621) * Early return scenarios * 10 minute cooldown tests --------- Co-authored-by: Colleen O'Rourke <[email protected]>
priscilawebdev
pushed a commit
that referenced
this pull request
Aug 25, 2025
Redo of #96221 after [adding an index](#97534) to the `GroupOpenPeriod`'s `data` column on `pending_incident_detector_id` which should hopefully not result in [the error](https://sentry.sentry.io/issues/6799376702/) anymore. There are no changes to this PR from the original one. --------- Co-authored-by: Snigdha Sharma <[email protected]>
priscilawebdev
pushed a commit
that referenced
this pull request
Aug 25, 2025
This reverts commit 433839b. Co-authored-by: ceorourke <[email protected]>
priscilawebdev
pushed a commit
that referenced
this pull request
Aug 25, 2025
3rd attempt at this PR - I merged #97621 but somehow hit a [circular import issue](https://github.com/getsentry/getsentry/actions/runs/16916645085/job/47932103426) that CI didn't catch. I've rebased after fixing the import issue. --------- Co-authored-by: Snigdha Sharma <[email protected]>
priscilawebdev
pushed a commit
that referenced
this pull request
Aug 25, 2025
…low engine (#95487) Duplicate tests from `subscription_processor.py` but rewritten for workflow engine. These will be used for single processing to ensure we don't lose test coverage. This has a lot of tests but isn't comprehensive, there will be follow up PRs for: * Anomaly detection tests * Adding `assert_open_period` and `assert_no_open_period` methods and adding those to tests (waiting on #97621) * Early return scenarios * 10 minute cooldown tests --------- Co-authored-by: Colleen O'Rourke <[email protected]>
andrewshie-sentry
pushed a commit
that referenced
this pull request
Aug 26, 2025
…low engine (#95487) Duplicate tests from `subscription_processor.py` but rewritten for workflow engine. These will be used for single processing to ensure we don't lose test coverage. This has a lot of tests but isn't comprehensive, there will be follow up PRs for: * Anomaly detection tests * Adding `assert_open_period` and `assert_no_open_period` methods and adding those to tests (waiting on #97621) * Early return scenarios * 10 minute cooldown tests --------- Co-authored-by: Colleen O'Rourke <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo of #96221 after adding an index to the
GroupOpenPeriod'sdatacolumn onpending_incident_detector_idwhich should hopefully not result in the error anymore. There are no changes to this PR from the original one.