feat(aci): Write to IncidentGroupOpenPeriod #97697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
ceorourke
force-pushed
the
ceorourke/write-incgroupopenperiod
branch
from
d696e89 to
00958f9
Compare
ceorourke
force-pushed
the
ceorourke/write-incgroupopenperiod
branch
from
00958f9 to
22820a8
Compare
saponifi3d
approved these changes
Aug 12, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Aug 12, 2025
3rd attempt at this PR - I merged #97621 but somehow hit a [circular import issue](https://github.com/getsentry/getsentry/actions/runs/16916645085/job/47932103426) that CI didn't catch. I've rebased after fixing the import issue. --------- Co-authored-by: Snigdha Sharma <[email protected]>
|
PR reverted: 466512b |
getsentry-bot
added a commit
that referenced
this pull request
Aug 13, 2025
This reverts commit e3849c5. Co-authored-by: ceorourke <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #97697 +/- ##
==========================================
+ Coverage 80.31% 80.64% +0.32%
==========================================
Files 8576 8576
Lines 377830 377897 +67
Branches 24585 24585
==========================================
+ Hits 303468 304764 +1296
+ Misses 73997 72768 -1229
Partials 365 365 |
ceorourke
added a commit
that referenced
this pull request
Aug 15, 2025
#97697 but it's behind a feature flag this time so we can toggle it on and off, plus converts incident projects to a list rather than passing a queryset. See [this commit](cd0b7f9) for the only change in this from the original implementation. --------- Co-authored-by: Snigdha Sharma <[email protected]>
evanh
pushed a commit
that referenced
this pull request
Aug 18, 2025
#97697 but it's behind a feature flag this time so we can toggle it on and off, plus converts incident projects to a list rather than passing a queryset. See [this commit](cd0b7f9) for the only change in this from the original implementation. --------- Co-authored-by: Snigdha Sharma <[email protected]>
priscilawebdev
pushed a commit
that referenced
this pull request
Aug 25, 2025
3rd attempt at this PR - I merged #97621 but somehow hit a [circular import issue](https://github.com/getsentry/getsentry/actions/runs/16916645085/job/47932103426) that CI didn't catch. I've rebased after fixing the import issue. --------- Co-authored-by: Snigdha Sharma <[email protected]>
priscilawebdev
pushed a commit
that referenced
this pull request
Aug 25, 2025
This reverts commit e3849c5. Co-authored-by: ceorourke <[email protected]>
priscilawebdev
pushed a commit
that referenced
this pull request
Aug 25, 2025
#97697 but it's behind a feature flag this time so we can toggle it on and off, plus converts incident projects to a list rather than passing a queryset. See [this commit](cd0b7f9) for the only change in this from the original implementation. --------- Co-authored-by: Snigdha Sharma <[email protected]>
andrewshie-sentry
pushed a commit
that referenced
this pull request
Aug 26, 2025
This reverts commit e3849c5. Co-authored-by: ceorourke <[email protected]>
andrewshie-sentry
pushed a commit
that referenced
this pull request
Aug 26, 2025
#97697 but it's behind a feature flag this time so we can toggle it on and off, plus converts incident projects to a list rather than passing a queryset. See [this commit](cd0b7f9) for the only change in this from the original implementation. --------- Co-authored-by: Snigdha Sharma <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3rd attempt at this PR - I merged #97621 but somehow hit a circular import issue that CI didn't catch. I've rebased after fixing the import issue.