Skip to content

Commit 5eaf4e9

Browse files
authored
fix(eap): handle null attribute values (#6837)
Closes https://github.com/getsentry/eap-planning/issues/169 - add null handling in results - make casted fields nullable - refactor Note: do not merge until sentry-side is updated to account for the new is_null boolean
1 parent a8f9563 commit 5eaf4e9

23 files changed

+698
-963
lines changed

.vscode/settings.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,4 +67,5 @@
6767
"python.testing.pytestArgs": ["tests"],
6868
"python.analysis.autoImportCompletions": true,
6969
"mypy-type-checker.args": ["--strict"]
70+
7071
}

snuba/datasets/configuration/events_analytics_platform/entities/eap_spans.yaml

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -73,21 +73,6 @@ query_processors:
7373
time_parse_columns:
7474
- start_timestamp
7575
- end_timestamp
76-
- processor: OptionalAttributeAggregationTransformer
77-
args:
78-
attribute_column_names:
79-
- attr_num
80-
aggregation_names:
81-
- sum
82-
- count
83-
- avg
84-
- avgWeighted
85-
- max
86-
- min
87-
- uniq
88-
curried_aggregation_names:
89-
- quantile
90-
- quantileTDigestWeighted
9176
- processor: HashBucketFunctionTransformer
9277
args:
9378
hash_bucket_names:

0 commit comments

Comments
 (0)