feat(autocomplete): Return boolean values as part of the item attribute names endpoint (#7647)

Co-authored-by: Claude Opus 4.5 <[email protected]>

Author: phacops

snuba/datasets/configuration/events_analytics_platform/storages/eap_item_co_occurring_attrs.yaml

@@ -20,7 +20,8 @@ schema:
 
       { name: attribute_keys_hash, type: Array, args: { inner_type: { type: UInt, args: { size: 64 } } } },
       { name: attributes_string, type: Array, args: { inner_type: { type: String } } },
-      { name: attributes_float, type: Array, args: { inner_type: { type: String } } }
+      { name: attributes_float, type: Array, args: { inner_type: { type: String } } },
+      { name: attributes_bool, type: Array, args: { inner_type: { type: String } } }
     ]
   local_table_name: eap_item_co_occurring_attrs_1_local
   dist_table_name: eap_item_co_occurring_attrs_1_dist

snuba/web/rpc/v1/endpoint_trace_item_attribute_names.py

@@ -214,18 +214,32 @@ def get_co_occurring_attributes(
         ),
         column("attributes_float"),
     )
+
+    bool_array = f.arrayMap(
+        Lambda(
+            None,
+            ("x",),
+            f.tuple(
+                "TYPE_BOOLEAN",
+                column("x"),
+            ),
+        ),
+        column("attributes_bool"),
+    )
+
     array_func = None
     if request.type == AttributeKey.Type.TYPE_STRING:
         array_func = string_array
     elif request.type in (
         AttributeKey.Type.TYPE_FLOAT,
         AttributeKey.Type.TYPE_DOUBLE,
         AttributeKey.Type.TYPE_INT,
-        AttributeKey.Type.TYPE_BOOLEAN,
     ):
         array_func = double_array
+    elif request.type == AttributeKey.Type.TYPE_BOOLEAN:
+        array_func = bool_array
     else:
-        array_func = f.arrayConcat(string_array, double_array)
+        array_func = f.arrayConcat(string_array, double_array, bool_array)
 
     attr_filter = not_cond(
         in_cond(

tests/web/rpc/v1/test_endpoint_trace_item_attribute_names.py

@@ -52,6 +52,7 @@ def generate_span_event_message(id: int) -> bytes:
             attributes[f"a_tag_{i:03}"] = AnyValue(string_value="blah")
             attributes[f"c_tag_{i:03}"] = AnyValue(string_value="blah")
             attributes[f"b_measurement_{i:03}"] = AnyValue(double_value=10)
+            attributes[f"d_bool_{i:03}"] = AnyValue(bool_value=i % 2 == 0)
         return gen_item_message(
             start_timestamp=BASE_TIME + timedelta(minutes=id),
             attributes=attributes,
@@ -234,3 +235,28 @@ def test_basic_co_occurring_attrs(self) -> None:
             ),
         ]
         assert res.attributes == expected
+
+    def test_simple_boolean(self) -> None:
+        req = TraceItemAttributeNamesRequest(
+            meta=RequestMeta(
+                project_ids=[1, 2, 3],
+                organization_id=1,
+                cogs_category="something",
+                referrer="something",
+                start_timestamp=Timestamp(seconds=int((BASE_TIME - timedelta(days=1)).timestamp())),
+                end_timestamp=Timestamp(seconds=int((BASE_TIME + timedelta(days=1)).timestamp())),
+            ),
+            limit=TOTAL_GENERATED_ATTR_PER_TYPE,
+            type=AttributeKey.Type.TYPE_BOOLEAN,
+            value_substring_match="d_bool",
+        )
+        res = EndpointTraceItemAttributeNames().execute(req)
+        expected = []
+        for i in range(TOTAL_GENERATED_ATTR_PER_TYPE):
+            expected.append(
+                TraceItemAttributeNamesResponse.Attribute(
+                    name=f"d_bool_{str(i).zfill(3)}",
+                    type=AttributeKey.Type.TYPE_BOOLEAN,
+                )
+            )
+        assert res.attributes == expected