fix(cdc): remove cdc stuff for real #6806
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
volokluev
force-pushed
the
volo/no_cdc_for_real
branch
from
5f40bec to
85648d0
Compare
|
This PR has a migration; here is the generated SQL for -- start migrations
-- forward migration events : 0007_groupedmessages
-- end forward migration events : 0007_groupedmessages
-- backward migration events : 0007_groupedmessages
-- end backward migration events : 0007_groupedmessages
-- forward migration events : 0008_groupassignees
-- end forward migration events : 0008_groupassignees
-- backward migration events : 0008_groupassignees
-- end backward migration events : 0008_groupassignees
-- forward migration events : 0010_groupedmessages_onpremise_compatibility
-- end forward migration events : 0010_groupedmessages_onpremise_compatibility
-- backward migration events : 0010_groupedmessages_onpremise_compatibility
-- end backward migration events : 0010_groupedmessages_onpremise_compatibility |
wedamija
approved these changes
Jan 23, 2025
Member
wedamija
left a comment
wedamija
left a comment
There was a problem hiding this comment.
lgtm, we haven't used this in issues for a long time
evanh
approved these changes
Jan 23, 2025
Member
|
@volokluev do you know why this wasn't merged in? Bit me when running migrations on |
Remove the `grouped` join relationship from events and discover_events entities as part of removing the groupedmessage CDC entity. Update test files to use profiles entity for join test fixtures instead. Co-Authored-By: Claude <[email protected]>
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Remove the `assigned` join relationship from events and discover_events entities as part of removing the groupassignee CDC entity. Update test files to remove all references to groupassignee and EntityKey.GROUPASSIGNEE. Co-Authored-By: Claude <[email protected]>
- Wrap Column in list for array_join and LimitBy arguments - Add type parameter to ProcessableQuery - Add type: ignore comments for test entity fixtures Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spiritual successor to #6804