Skip to content

fix: Handle columns without a column type in TraceItemTableRequestVisitor #7504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
+11 −11
Draft

fix: Handle columns without a column type in TraceItemTableRequestVisitor #7504

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
754d07b
fix: Handle columns without a column type in TraceItemTableRequestVis…
seer-by-sentry[bot] Nov 4, 2025
a9e1ce1
[getsentry/action-github-commit] Auto commit
getsantry[bot] Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions snuba/web/rpc/v1/visitors/trace_item_table_request_visitor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,7 @@ def visit_TraceItemTableRequest(self, node: TraceItemTableRequest) -> None:
if column.label == "":
continue
if column.label in self.column_labels:
raise BadSnubaRPCRequestException(
f"Duplicate column label: {column.label}"
)
raise BadSnubaRPCRequestException(f"Duplicate column label: {column.label}")
self.column_labels.add(column.label)

for column in node.columns:
Expand Down Expand Up @@ -113,7 +111,13 @@ def visit_TraceItemTableRequest(self, node: TraceItemTableRequest) -> None:
def visit_Column(self, node: Column, new_label: str) -> None:
node.label = new_label

match node.WhichOneof("column"):
column_type = node.WhichOneof("column")
# Handle columns that only have a label but no column type
# (e.g., order_by columns that reference existing columns by label)
if column_type is None:
return

match column_type:
case "key":
self.visit(node.key, new_label)
case "aggregation":
Expand All @@ -125,14 +129,12 @@ def visit_Column(self, node: Column, new_label: str) -> None:
case "literal":
self.visit(node.literal, new_label)
case _:
raise ValueError(f"Unknown column type: {node.WhichOneof('column')}")
raise ValueError(f"Unknown column type: {column_type}")

def visit_AttributeKey(self, node: AttributeKey, new_label: str) -> None:
return

def visit_AttributeAggregation(
self, node: AttributeAggregation, new_label: str
) -> None:
def visit_AttributeAggregation(self, node: AttributeAggregation, new_label: str) -> None:
node.label = new_label

def visit_AttributeConditionalAggregation(
Expand Down Expand Up @@ -188,7 +190,5 @@ def visit_Column(self, node: Column) -> None:
def visit_AttributeAggregation(self, node: AttributeAggregation) -> None:
node.label = self.current_label

def visit_AttributeConditionalAggregation(
self, node: AttributeConditionalAggregation
) -> None:
def visit_AttributeConditionalAggregation(self, node: AttributeConditionalAggregation) -> None:
node.label = self.current_label
Loading