Skip to content

chore(metrics): don't write the histogram timing metrics #7616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
volokluev merged 1 commit into from
Jan 5, 2026
Merged

chore(metrics): don't write the histogram timing metrics #7616

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions snuba/utils/metrics/backends/dualwrite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@ def _use_sentry(self) -> bool:
return bool(random.random() < settings.DDM_METRICS_SAMPLE_RATE)
return False

def _write_timings_as_distributions(self) -> bool:
def _write_timings_as_histograms(self) -> bool:
from snuba import state

return str(state.get_config("write_timings_as_distributions", "0")) == "1"
return str(state.get_config("write_timings_as_histograms", "1")) == "1"

def increment(
self,
Expand Down Expand Up @@ -67,11 +67,11 @@ def timing(
# would then calculate percentiles. datadog now supports direct aggregations of percentiles
# we keep the veneur timing metric to maintain historical data, this should be removed by
# 02/15/2026 once we have enough historical data already
self.datadog.timing(name, value, tags, unit)
self.datadog.distribution(f"{name}.distribution", value, tags, unit)
if self._write_timings_as_histograms():
self.datadog.timing(name, value, tags, unit)
if self._use_sentry():
self.sentry.timing(name, value, tags, unit)
if self._write_timings_as_distributions():
self.datadog.distribution(f"{name}.distribution", value, tags, unit)

def distribution(
self,
Expand Down
Loading