feat(ast): add ArbitrarySQL AST node to allow for subquery optimization #7636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove truncation logic from visit_arbitrary_sql to always display the full SQL query, and remove the corresponding test case that expected truncation behavior. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
onewland
approved these changes
Jan 13, 2026
| @dataclass(frozen=True, repr=_AUTO_REPR) | ||
| class ArbitrarySQL(Expression): | ||
| """ | ||
| Represents raw SQL that should be passed through directly to ClickHouse |
Contributor
There was a problem hiding this comment.
RawSQL / DangerousSQL / UnescapedSQL might be better to make usage of this stick out in bad situations
Renamed the ArbitrarySQL class to DangerousRawSQL to better reflect the dangerous nature of this expression type that bypasses safety checks. Changes: - Renamed class from ArbitrarySQL to DangerousRawSQL - Renamed visitor method from visit_arbitrary_sql to visit_dangerous_raw_sql - Updated all implementations across 8 source files and 4 test files - All 102 tests passing Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For cross item queries to work, we need to be able to put a subquery into an AST node. Rather than modifying the whole query pipeline to be able to do this, take a shortcut and add an
ArbitrarySQLnode that is not transformed in any way by the query pipeline but can be inserted into a manually constructed EAP query (as we do in EAP)The query I want to be able to build is :