Skip to content

Kill Veneur metrics for good #7637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
volokluev merged 1 commit into from
Jan 13, 2026
Merged

Kill Veneur metrics for good #7637

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions snuba/utils/metrics/backends/dualwrite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,6 @@ def _use_sentry(self) -> bool:
return bool(random.random() < settings.DDM_METRICS_SAMPLE_RATE)
return False

def _write_timings_as_histograms(self) -> bool:
from snuba import state

return str(state.get_config("write_timings_as_histograms", "1")) == "1"

def increment(
self,
name: str,
Expand Down Expand Up @@ -64,12 +59,10 @@ def timing(
unit: str | None = None,
) -> None:
# Note (Volo) 12/15/2025: timing metrics were originally written to veneur which
# would then calculate percentiles. datadog now supports direct aggregations of percentiles
# we keep the veneur timing metric to maintain historical data, this should be removed by
# 02/15/2026 once we have enough historical data already
# would then calculate percentiles. These would be saved as histograms in datadog
# datadog now supports direct aggregations of percentiles using distribution metrics
# so we send our timings using a distribution metric
self.datadog.distribution(f"{name}.distribution", value, tags, unit)
if self._write_timings_as_histograms():
self.datadog.timing(name, value, tags, unit)
if self._use_sentry():
self.sentry.timing(name, value, tags, unit)

Expand Down
Loading