feat(capman): add detailed observability to allocation policy span data #7638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The allocation policy now includes storage_key in the explanation field for better observability. Updated the test expectations to match this new behavior. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
The allocation policy changes added instrumentation that iterates over tenant_ids.items(), but tests were using bare mock.Mock() objects for attribution_info. This caused 'Mock' object is not iterable errors. Fixed by configuring mocks with proper tenant_ids dictionaries. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
onewland
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sentry has great tools to be able to understand allocation policy decisions in aggregate using span data. Add tenant id information and quota allowance information to the span in order to better dissect these errors using our tooling