fix(deploy): CI mypy #7663
Merged
fix(deploy): CI mypy #7663
+14
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes a mypy CI error by adding proper type annotations to a wrapper function in the test suite, replacing the # type: ignore[no-untyped-def] comment with explicit type hints.
Changes:
- Updated the
wrapperfunction signature intest_no_transformation_on_order_bytest to include explicit type annotations for all parameters
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+624
to
+630
| def wrapper( | ||
| dataset: Any, | ||
| request: Any, | ||
| timer: Any, | ||
| robust: bool = False, | ||
| concurrent_queries_gauge: Any | None = None, | ||
| ) -> QueryResult: |
There was a problem hiding this comment.
This fix addresses the mypy error by adding proper type annotations to the wrapper function. However, there's an identical pattern in tests/web/rpc/v1/test_endpoint_export_trace_items.py at line 135 that still uses # type: ignore[no-untyped-def]. For consistency and to prevent similar mypy errors in the future, that instance should also be updated with the same type annotations.
Add type hints to wrapper function to remove type: ignore comment. Co-Authored-By: Claude Opus 4.5 <[email protected]>
phacops
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: https://github.com/getsentry/snuba/actions/runs/21256943251/job/61174039415