fix(preprod): Delete EAP data by trace_id instead of attribute #7686
+0
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where deleting preprod artifacts would fail with a
SnubaRPCError: code: 500.The root cause was that the Sentry code was attempting to delete preprod data from Snuba's EAP storage by filtering on the
preprod_artifact_idattribute. However, Snuba's EAP storage configuration (eap_items.yaml) does not allow attribute-based deletions for thepreproditem type, leading to the error: "No attribute-based deletions configured for item_type preprod".The solution changes the deletion logic in
sentry/preprod/helpers/deletion.pyto filter bytrace_idinstead. Thetrace_idis a standard column in EAP storage and is deterministically generated from thepreprod_artifact_idusinguuid.uuid5(PREPROD_NAMESPACE, str(artifact_id)).hexin the write path. This ensures that the deletion request uses a supported filter, resolving theSnubaRPCError.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.