Skip to content

Dependency security updates #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BYK merged 2 commits into from
Dec 31, 2025
Merged

Dependency security updates #1225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29671d4
Update dependencies and Sentry packages
cursoragent Dec 31, 2025
3e69236
fix: constrain brace-expansion to 2.x for CommonJS compatibility
cursoragent Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,19 @@
"cross-spawn": ">=7.0.5",
"form-data": ">=4.0.4",
"devalue": ">=5.3.2",
"next": "^15.4.8"
"next": "^15.4.8",
"cookie": ">=0.7.0",
"esbuild": ">=0.25.0",
"brace-expansion": ">=2.0.2 <3",
"tmp": ">=0.2.4",
"js-yaml": ">=4.1.1",
"body-parser": ">=2.2.1",
"mdast-util-to-hast": ">=13.2.1"
},
"pnpm": {
"overrides": {
"vite@>=6.0.0 <6.3.6": ">=6.3.6"
Copy link

@sentry sentry bot Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The pnpm override for vite uses >=6.3.6, which will pull in vite 7.0.0 (a major version with breaking changes), instead of staying within the 6.x range.
Severity: CRITICAL | Confidence: High

🔍 Detailed Analysis

The pnpm override "vite@>=6.0.0 <6.3.6": ">=6.3.6" in package.json will resolve to the latest available version of vite, which is 7.0.0. This major version introduces breaking changes, such as requiring Node.js 20.19+ and removing the splitVendorChunkPlugin. The packages/website workspace, which depends on astro (which in turn uses vite 6.x), will be forced to use vite 7.0.0. This will likely cause build failures due to the breaking changes. This also creates inconsistent vite versions across the monorepo.

💡 Suggested Fix

Change the override value from >=6.3.6 to ^6.3.6. This will ensure that only versions within the 6.x range are installed, preventing the automatic upgrade to the breaking 7.0.0 major version while still applying the intended security fix.

🤖 Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: package.json#L44

Potential issue: The `pnpm` override `"vite@>=6.0.0 <6.3.6": ">=6.3.6"` in
`package.json` will resolve to the latest available version of `vite`, which is `7.0.0`.
This major version introduces breaking changes, such as requiring Node.js 20.19+ and
removing the `splitVendorChunkPlugin`. The `packages/website` workspace, which depends
on `astro` (which in turn uses `vite` 6.x), will be forced to use `vite` 7.0.0. This
will likely cause build failures due to the breaking changes. This also creates
inconsistent `vite` versions across the monorepo.

Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 8075914

}
},
"simple-git-hooks": {
"pre-commit": "pnpm exec lint-staged --concurrent false"
Expand Down
6 changes: 3 additions & 3 deletions packages/spotlight/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,9 @@
"@radix-ui/react-dropdown-menu": "^2.1.15",
"@radix-ui/react-slot": "^1.2.3",
"@radix-ui/react-tooltip": "^1.2.7",
"@sentry/browser": "^10.26.0",
"@sentry/electron": "^7.3.0",
"@sentry/react": "^10.26.0",
"@sentry/browser": "^10.31.0",
"@sentry/electron": "^7.5.0",
"@sentry/react": "^10.31.0",
"@sentry/vite-plugin": "^2.22.5",
"@shikijs/transformers": "^3.13.0",
"@tailwindcss/vite": "catalog:",
Expand Down
Loading
Loading