Node 24.x support #1235
Merged
Node 24.x support #1235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lity Co-authored-by: burak.kaya <[email protected]>
|
Cursor Agent can help with this pull request. Just |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Add inject: false to Sentry Vite plugin options to prevent virtual module injection that causes circular dependency issues with preserveModules - Remove conditional shouldUseSentryPlugin() - plugin now always runs safely - Update Volta to Node 24.11.1 for building fossilized binaries - Delete obsolete changeset file The release is already set via Sentry.init() at runtime, making build-time injection redundant. This fix works for all users regardless of environment. Fixes #1231
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1231
Changes
inject: falsein Sentry Vite plugin to disable virtual module injectionWhy?
The Sentry Vite plugin's
_virtual/_sentry-release-injection-file.jscreates circular dependency issues in Node 24.x when combined withpreserveModules: true. Since Spotlight already sets the release viaSentry.init()at runtime, the build-time injection is redundant.This fix ensures the plugin still uploads source maps while avoiding the Node 24.x compatibility issue.