Skip to content

fix(ui): Handle null/undefined span.description safely #1239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BYK merged 1 commit into from
Jan 8, 2026
+2 −2
Merged

fix(ui): Handle null/undefined span.description safely #1239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/spotlight/src/ui/telemetry/components/insights/Queries.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ const Queries = () => {
const compareQueryInfo = COMPARATORS[sort.active] || COMPARATORS[QUERIES_SORT_KEYS.totalTime];
const spans = allSpans;
const onlyDBSpans = spans.filter((span: Span) => DB_SPAN_REGEX.test(span.op || ""));
const uniqueSpansSet = new Set(onlyDBSpans.map(span => String(span?.description).trim()));
const uniqueSpansSet = new Set(onlyDBSpans.map(span => (span.description ?? "").trim()));
// Clear out empty ones (they collapse as a single empty string since this is a set)
uniqueSpansSet.delete("");
return [...uniqueSpansSet]
Expand Down
2 changes: 1 addition & 1 deletion packages/spotlight/src/ui/telemetry/components/insights/Resources.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ const Resources = () => {

const resources = useMemo(() => {
const filteredResourceSpans = getResourceSpans(allSpans, { regex: /resource\.[A-Za-z]+/ });
const uniqueResourceDescriptionsSet = new Set(filteredResourceSpans.map(span => String(span?.description).trim()));
const uniqueResourceDescriptionsSet = new Set(filteredResourceSpans.map(span => (span.description ?? "").trim()));
// Clear out empty ones (they collapse as a single empty string since this is a set)
uniqueResourceDescriptionsSet.delete("");
const uniqueResourceDescriptions: string[] = [...uniqueResourceDescriptionsSet];
Expand Down
Loading