fix: restore download functionality for text-based attachments #1244
+227
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
The refactoring in #1237 accidentally broke download links for text-based attachments (txt, csv, json, code files) by returning undefined instead of creating a blob URL. This restores the original behavior where all content types get a blob URL for downloading. Also adds comprehensive unit tests for the Attachment component to prevent future regressions: - Download URL generation for various content types - Error handling for invalid base64 data - Content preview rendering - Blob URL cleanup on unmount
BYK
force-pushed
the
fix/attachment-text-download
branch
from
51e677f to
3b4c987
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The refactoring in #1237 accidentally broke download links for text-based attachments (txt, csv, json, code files) by returning
undefinedinstead of creating a blob URL.Solution
Restore the original behavior where all content types get a blob URL for downloading. The
elsebranch now creates a blob from the raw attachment string instead of returningundefined.Testing
All 172 tests pass.