Skip to content

fix: Always try to use sidecar along with direct SDK transport#672

Merged
BYK merged 1 commit intomainfrom
zxvkppzvrmsu
Jan 24, 2025
Merged

fix: Always try to use sidecar along with direct SDK transport#672
BYK merged 1 commit intomainfrom
zxvkppzvrmsu

Conversation

@BYK
Copy link
Member

@BYK BYK commented Jan 23, 2025

Fixes #669

@vercel
Copy link

vercel bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spotlightjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 0:12am

@BYK BYK changed the title zxvkppzvrmsu fix: Use sidecar when it is available for local JS Jan 23, 2025
@codecov
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 12 lines in your changes missing coverage. Please review.

Project coverage is 31.31%. Comparing base (f3d71f2) to head (1c64c83).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/overlay/src/integrations/sentry/index.ts 16.66% 10 Missing ⚠️
...rlay/src/integrations/sentry/sentry-integration.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #672      +/-   ##
==========================================
- Coverage   31.35%   31.31%   -0.05%     
==========================================
  Files          92       92              
  Lines        5435     5439       +4     
  Branches      101      100       -1     
==========================================
- Hits         1704     1703       -1     
- Misses       3731     3736       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BYK BYK requested a review from dcramer January 23, 2025 22:52
@BYK BYK enabled auto-merge (squash) January 23, 2025 22:52
@BYK BYK disabled auto-merge January 23, 2025 22:52
@BYK BYK changed the title fix: Use sidecar when it is available for local JS fix: Always try to use sidecar along with direct SDK transport Jan 24, 2025
@BYK BYK enabled auto-merge (squash) January 24, 2025 00:06
@BYK BYK merged commit 03e386a into main Jan 24, 2025
16 of 17 checks passed
@BYK BYK deleted the zxvkppzvrmsu branch January 24, 2025 00:14
BYK pushed a commit that referenced this pull request Jan 24, 2025
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and publish to npm
yourself or [setup this action to publish
automatically](https://github.com/changesets/action#with-publishing). If
you're not ready to do a release yet, that's fine, whenever you add more
changesets to main, this PR will be updated.


# Releases
## @spotlightjs/astro@2.4.1

### Patch Changes

-   Updated dependencies \[]:
    -   @spotlightjs/spotlight@2.10.1

## @spotlightjs/electron@1.4.1

### Patch Changes

-   Updated dependencies

\[[`03e386af2024eda44c02952a06433e4d4ecb3356`](03e386a),

[`416fecd778d4829d490b07ec4d500946fa439210`](416fecd)]:
    -   @spotlightjs/overlay@2.10.1
    -   @spotlightjs/sidecar@1.11.1

## @spotlightjs/overlay@2.10.1

### Patch Changes

-   fix: Always try to use sidecar along with direct SDK transport
    ([#672](#672))

## @spotlightjs/sidecar@1.11.1

### Patch Changes

- Fix invalid semver range for source-map dependency
([#667](#667))

## @spotlightjs/spotlight@2.10.1

### Patch Changes

-   Updated dependencies

\[[`03e386af2024eda44c02952a06433e4d4ecb3356`](03e386a),

[`416fecd778d4829d490b07ec4d500946fa439210`](416fecd)]:
    -   @spotlightjs/overlay@2.10.1
    -   @spotlightjs/sidecar@1.11.1

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dcramer pushed a commit that referenced this pull request Jun 3, 2025
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and publish to npm
yourself or [setup this action to publish
automatically](https://github.com/changesets/action#with-publishing). If
you're not ready to do a release yet, that's fine, whenever you add more
changesets to main, this PR will be updated.


# Releases
## @spotlightjs/astro@2.4.1

### Patch Changes

-   Updated dependencies \[]:
    -   @spotlightjs/spotlight@2.10.1

## @spotlightjs/electron@1.4.1

### Patch Changes

-   Updated dependencies

\[[`03e386af2024eda44c02952a06433e4d4ecb3356`](03e386a),

[`416fecd778d4829d490b07ec4d500946fa439210`](416fecd)]:
    -   @spotlightjs/overlay@2.10.1
    -   @spotlightjs/sidecar@1.11.1

## @spotlightjs/overlay@2.10.1

### Patch Changes

-   fix: Always try to use sidecar along with direct SDK transport
    ([#672](#672))

## @spotlightjs/sidecar@1.11.1

### Patch Changes

- Fix invalid semver range for source-map dependency
([#667](#667))

## @spotlightjs/spotlight@2.10.1

### Patch Changes

-   Updated dependencies

\[[`03e386af2024eda44c02952a06433e4d4ecb3356`](03e386a),

[`416fecd778d4829d490b07ec4d500946fa439210`](416fecd)]:
    -   @spotlightjs/overlay@2.10.1
    -   @spotlightjs/sidecar@1.11.1

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spotlight bypasses sidecar while embedded

2 participants