Skip to content

ref: Fix some typing errors in sentryDataCache #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BYK merged 1 commit into from
Feb 4, 2025
Merged

ref: Fix some typing errors in sentryDataCache #691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/blue-jars-peel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
'@spotlightjs/spotlight': patch
'@spotlightjs/electron': patch
'@spotlightjs/overlay': patch
'@spotlightjs/astro': patch
---

Fix some typing issues in sentryDataCache
8 changes: 4 additions & 4 deletions packages/overlay/src/integrations/sentry/data/sentryDataCache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { Envelope } from '@sentry/types';
import type { Envelope } from '@sentry/core';
import { CONTEXT_LINES_ENDPOINT } from '@spotlightjs/sidecar/constants';
import { DEFAULT_SIDECAR_URL } from '~/constants';
import type { RawEventContext } from '~/integrations/integration';
Expand Down Expand Up @@ -73,7 +73,7 @@ class SentryDataCache {
const lastSeen = new Date(header.sent_at as string).getTime();
let sdk: Sdk;

if (header.sdk && header.sdk.name && header.sdk.version) {
if (header.sdk?.name && header.sdk.version) {
sdk = {
name: header.sdk.name,
version: header.sdk.version,
Expand Down Expand Up @@ -139,7 +139,7 @@ class SentryDataCache {
const startTs = event.start_timestamp ? event.start_timestamp : new Date().getTime();
const trace = existingTrace ?? {
...traceCtx,
spans: [] as Span[],
spans: new Map(),
transactions: [] as SentryTransactionEvent[],
errors: 0,
timestamp: event.timestamp,
Expand Down Expand Up @@ -324,5 +324,5 @@ class SentryDataCache {
export default new SentryDataCache();

function isErrorEvent(event: SentryEvent): event is SentryErrorEvent {
return event.type != 'transaction';
return event.type !== 'transaction';
}