Skip to content

feat: Add a way to download raw envelopes#729

Merged
BYK merged 1 commit intomainfrom
pmnzpurxtplv
Mar 7, 2025
Merged

feat: Add a way to download raw envelopes#729
BYK merged 1 commit intomainfrom
pmnzpurxtplv

Conversation

@BYK
Copy link
Member

@BYK BYK commented Mar 6, 2025

Fixes #655.

image

Clicking on the event id now directly downloads it with a .bin file extension. We can make this .txt but there indeed are binary envelopes that might get corrupted this way.

@vercel
Copy link

vercel bot commented Mar 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spotlightjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2025 8:48pm

@BYK BYK requested a review from dcramer March 6, 2025 20:47
@codecov
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 31.95%. Comparing base (97dfa76) to head (8907578).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...y/components/explore/envelopes/EnvelopeDetails.tsx 11.11% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #729      +/-   ##
==========================================
- Coverage   31.96%   31.95%   -0.02%     
==========================================
  Files          92       92              
  Lines        5834     5837       +3     
  Branches      118      118              
==========================================
  Hits         1865     1865              
- Misses       3969     3972       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BYK BYK merged commit c39cfb3 into main Mar 7, 2025
15 of 17 checks passed
@BYK BYK deleted the pmnzpurxtplv branch March 7, 2025 10:47
BYK pushed a commit that referenced this pull request Mar 13, 2025
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and publish to npm
yourself or [setup this action to publish
automatically](https://github.com/changesets/action#with-publishing). If
you're not ready to do a release yet, that's fine, whenever you add more
changesets to main, this PR will be updated.


# Releases
## @spotlightjs/astro@3.1.0

### Minor Changes

-   Make event id a link to raw envelope on envelope details page
    ([#729](#729))

### Patch Changes

- Fix envelope sorting and local classification
([#727](#727))

- Fix UI issues when we get a bare span envelope
([#726](#726))

- Fix span details modal resetting trace view tree state on close (for
reals this time)
    ([#728](#728))

- Fixes detection of Sentry SDK frames in Vite projects
([#718](#718))

-   Updated dependencies

\[[`9ca9ed1b97119757d8b1ec6de24d781aefe8b76c`](9ca9ed1),

[`c39cfb3622fe19ccc5df822d30d16298f254cb17`](c39cfb3),

[`f731d9171ead5aea21152f1d3bfa89e473a7272c`](f731d91),

[`97dfa768846c76da47521f551b1bb45c683a23d9`](97dfa76),

[`79506149f545487e67cdff7eab7393c619c8afd9`](7950614)]:
    -   @spotlightjs/spotlight@2.12.0

## @spotlightjs/electron@1.6.0

### Minor Changes

-   Make event id a link to raw envelope on envelope details page
    ([#729](#729))

### Patch Changes

- Fix envelope sorting and local classification
([#727](#727))

- Fix UI issues when we get a bare span envelope
([#726](#726))

- Fix span details modal resetting trace view tree state on close (for
reals this time)
    ([#728](#728))

- Fixes detection of Sentry SDK frames in Vite projects
([#718](#718))

-   Updated dependencies

\[[`9ca9ed1b97119757d8b1ec6de24d781aefe8b76c`](9ca9ed1),

[`c39cfb3622fe19ccc5df822d30d16298f254cb17`](c39cfb3),

[`f731d9171ead5aea21152f1d3bfa89e473a7272c`](f731d91),

[`97dfa768846c76da47521f551b1bb45c683a23d9`](97dfa76),

[`448062fd45799832fc3240656d543696d438d5ab`](448062f),

[`79506149f545487e67cdff7eab7393c619c8afd9`](7950614)]:
    -   @spotlightjs/overlay@2.13.0

## @spotlightjs/overlay@2.13.0

### Minor Changes

-   Make event id a link to raw envelope on envelope details page
    ([#729](#729))

- Added Search support in Trace details
([#730](#730))

### Patch Changes

- Fix envelope sorting and local classification
([#727](#727))

- Fix UI issues when we get a bare span envelope
([#726](#726))

- Fix span details modal resetting trace view tree state on close (for
reals this time)
    ([#728](#728))

- Fixes detection of Sentry SDK frames in Vite projects
([#718](#718))

## @spotlightjs/spotlight@2.12.0

### Minor Changes

-   Make event id a link to raw envelope on envelope details page
    ([#729](#729))

### Patch Changes

- Fix envelope sorting and local classification
([#727](#727))

- Fix UI issues when we get a bare span envelope
([#726](#726))

- Fix span details modal resetting trace view tree state on close (for
reals this time)
    ([#728](#728))

- Fixes detection of Sentry SDK frames in Vite projects
([#718](#718))

-   Updated dependencies

\[[`9ca9ed1b97119757d8b1ec6de24d781aefe8b76c`](9ca9ed1),

[`c39cfb3622fe19ccc5df822d30d16298f254cb17`](c39cfb3),

[`f731d9171ead5aea21152f1d3bfa89e473a7272c`](f731d91),

[`97dfa768846c76da47521f551b1bb45c683a23d9`](97dfa76),

[`448062fd45799832fc3240656d543696d438d5ab`](448062f),

[`79506149f545487e67cdff7eab7393c619c8afd9`](7950614)]:
    -   @spotlightjs/overlay@2.13.0

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
dcramer pushed a commit that referenced this pull request Jun 3, 2025
Fixes #655.


![image](https://github.com/user-attachments/assets/4e94dbf6-f24e-40a2-bf8f-2259cc92f02c)

Clicking on the event id now directly downloads it with a `.bin` file
extension. We can make this `.txt` but there indeed are binary envelopes
that might get corrupted this way.
dcramer pushed a commit that referenced this pull request Jun 3, 2025
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and publish to npm
yourself or [setup this action to publish
automatically](https://github.com/changesets/action#with-publishing). If
you're not ready to do a release yet, that's fine, whenever you add more
changesets to main, this PR will be updated.


# Releases
## @spotlightjs/astro@3.1.0

### Minor Changes

-   Make event id a link to raw envelope on envelope details page
    ([#729](#729))

### Patch Changes

- Fix envelope sorting and local classification
([#727](#727))

- Fix UI issues when we get a bare span envelope
([#726](#726))

- Fix span details modal resetting trace view tree state on close (for
reals this time)
    ([#728](#728))

- Fixes detection of Sentry SDK frames in Vite projects
([#718](#718))

-   Updated dependencies

\[[`9ca9ed1b97119757d8b1ec6de24d781aefe8b76c`](9ca9ed1),

[`c39cfb3622fe19ccc5df822d30d16298f254cb17`](c39cfb3),

[`f731d9171ead5aea21152f1d3bfa89e473a7272c`](f731d91),

[`97dfa768846c76da47521f551b1bb45c683a23d9`](97dfa76),

[`79506149f545487e67cdff7eab7393c619c8afd9`](7950614)]:
    -   @spotlightjs/spotlight@2.12.0

## @spotlightjs/electron@1.6.0

### Minor Changes

-   Make event id a link to raw envelope on envelope details page
    ([#729](#729))

### Patch Changes

- Fix envelope sorting and local classification
([#727](#727))

- Fix UI issues when we get a bare span envelope
([#726](#726))

- Fix span details modal resetting trace view tree state on close (for
reals this time)
    ([#728](#728))

- Fixes detection of Sentry SDK frames in Vite projects
([#718](#718))

-   Updated dependencies

\[[`9ca9ed1b97119757d8b1ec6de24d781aefe8b76c`](9ca9ed1),

[`c39cfb3622fe19ccc5df822d30d16298f254cb17`](c39cfb3),

[`f731d9171ead5aea21152f1d3bfa89e473a7272c`](f731d91),

[`97dfa768846c76da47521f551b1bb45c683a23d9`](97dfa76),

[`448062fd45799832fc3240656d543696d438d5ab`](448062f),

[`79506149f545487e67cdff7eab7393c619c8afd9`](7950614)]:
    -   @spotlightjs/overlay@2.13.0

## @spotlightjs/overlay@2.13.0

### Minor Changes

-   Make event id a link to raw envelope on envelope details page
    ([#729](#729))

- Added Search support in Trace details
([#730](#730))

### Patch Changes

- Fix envelope sorting and local classification
([#727](#727))

- Fix UI issues when we get a bare span envelope
([#726](#726))

- Fix span details modal resetting trace view tree state on close (for
reals this time)
    ([#728](#728))

- Fixes detection of Sentry SDK frames in Vite projects
([#718](#718))

## @spotlightjs/spotlight@2.12.0

### Minor Changes

-   Make event id a link to raw envelope on envelope details page
    ([#729](#729))

### Patch Changes

- Fix envelope sorting and local classification
([#727](#727))

- Fix UI issues when we get a bare span envelope
([#726](#726))

- Fix span details modal resetting trace view tree state on close (for
reals this time)
    ([#728](#728))

- Fixes detection of Sentry SDK frames in Vite projects
([#718](#718))

-   Updated dependencies

\[[`9ca9ed1b97119757d8b1ec6de24d781aefe8b76c`](9ca9ed1),

[`c39cfb3622fe19ccc5df822d30d16298f254cb17`](c39cfb3),

[`f731d9171ead5aea21152f1d3bfa89e473a7272c`](f731d91),

[`97dfa768846c76da47521f551b1bb45c683a23d9`](97dfa76),

[`448062fd45799832fc3240656d543696d438d5ab`](448062f),

[`79506149f545487e67cdff7eab7393c619c8afd9`](7950614)]:
    -   @spotlightjs/overlay@2.13.0

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Action to download raw events

1 participant