ci: provide arm64 image for taskbroker #405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
/gcbrun |
evanh
reviewed
Jun 9, 2025
| docker manifest create \ | ||
| ghcr.io/getsentry/taskbroker:${{ github.sha }} \ | ||
| ghcr.io/getsentry/taskbroker:latest \ |
Member
There was a problem hiding this comment.
All of our deploys using the latest image I believe. I'm not an expert on docker manifests: will this expose that image so deploys continue to work?
Member
There was a problem hiding this comment.
All of our deploys using the latest image I believe.
The deploys under the hood use a fixed sha, but also just the ones published to the google registry (not ghcr).
evanh
approved these changes
Jun 9, 2025
Member
|
/gcbrun |
Collaborator
Author
|
@evanh @markstory what's blocking this PR? |
Member
|
/gcbrun |
|
PR reverted: 32f1e94 |
sentry-taskbroker-fast-revert-bot bot
pushed a commit
that referenced
this pull request
Jun 11, 2025
This reverts commit d32e924. Co-authored-by: markstory <[email protected]>
Member
|
I reverted this change as it failed to run https://github.com/getsentry/taskbroker/actions/runs/15588079414 |
Collaborator
Author
|
Let me fix that in a few hours |
Collaborator
Author
|
second attempt here: #412 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @markstory @mdtro