fix: Make CI works for external contributors #503
Conversation
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
| uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2 | ||
| if: ${{ github.event_name == 'pull_request' }} | ||
| with: | ||
| name: taskbroker-${{ matrix.platform }} |
There was a problem hiding this comment.
What happens if there are two pull requests open at the same time? Could they conflict over this name?
There was a problem hiding this comment.
Nope. Github artifact is unique per commit run.
.github/workflows/image.yml
Outdated
| dockerfile_path: './Dockerfile' | ||
| build_args: TASKBROKER_GIT_REVISION=${{ github.sha }} | ||
| ghcr: true | ||
| ghcr: ${{ github.event_name != 'pull_request' }} |
There was a problem hiding this comment.
We use the images built from pull requests to do testing in non-production sandboxes. It would be good to keep that workflow available for staff.
There was a problem hiding this comment.
Ah that's a bit hard. I'll see what I can do tomorrow.
| uses: docker/setup-buildx-action@b5ca514318bd6ebac0fb2aedd5d36ec1b5c232a2 # v3.10.0 | ||
|
|
||
| - name: Create multiplatform manifests | ||
| if: ${{ (github.ref_name == 'main' || startsWith(github.ref_name, 'releases/')) && github.event_name != 'pull_request' }} |
There was a problem hiding this comment.
Won't we run the first two steps in this workflow all the time now?
|
I'm going to revert this because builds are failing for my branches after this change. https://github.com/getsentry/taskbroker/actions/runs/19141787824/job/54709177819 |
|
PR reverted: 5521341 |
This reverts commit 836026f. Co-authored-by: evanh <[email protected]>
3 participants
Similar stuff to how snuba's
ci.ymlworks.