feat(kafka): Trigger graceful shutdown on actor failure #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-z-yang
force-pushed
the
john/shutdown-on-actor-failure
branch
from
455693a to
dd9b935
Compare
evanh
approved these changes
Dec 5, 2024
markstory
approved these changes
Dec 5, 2024
john-z-yang
force-pushed
the
john/shutdown-on-actor-failure
branch
3 times, most recently
from
7fb90c6 to
caef930
Compare
john-z-yang
force-pushed
the
john/shutdown-on-actor-failure
branch
from
caef930 to
5f3e940
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds a
select!clause in the event handling loop to check for actor termination outside of an event and shutdown the entire program if so. As actors should only be terminated on shutdown/rebalancing