Skip to content

Fix "you must first set a package to build it" error #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EbonJaeger merged 2 commits into from
Sep 6, 2025
Merged

Fix "you must first set a package to build it" error #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9f3eab
Fix building packages
silkeh Sep 6, 2025
56fc27a
Update version to 1.8.1
silkeh Sep 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
VERSION := 1.8.0
VERSION := 1.8.1
BINNAME := solbuild

.PHONY: build
Expand Down
15 changes: 7 additions & 8 deletions builder/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,15 +405,10 @@ func (m *Manager) Chroot() error {
return ErrInterrupted
}

m.lock.Lock()

if m.pkg == nil {
m.lock.Unlock()
return ErrNoPackage
if err := m.checkPackage(); err != nil {
return err
}

m.lock.Unlock()

// Now get on with the real work!
defer m.Cleanup()

Expand Down Expand Up @@ -512,5 +507,9 @@ func (m *Manager) checkPackage() error {
m.lock.Lock()
defer m.lock.Unlock()

return ErrNoPackage
if m.pkg == nil {
return ErrNoPackage
}

return nil
}