Skip to content

Conversation

@albinvass
Copy link

This PR rebases and continues #1134

@devstein devstein requested review from a team and hiddeco April 30, 2024 15:07
if err != nil {
return nil, err
}
defer in.Close()

Check warning

Code scanning / CodeQL

Writable file handle closed without error handling

File handle may be writable as a result of data flow from a [call to OpenFile](1) and closing it may result in data loss upon failure, which is not handled explicitly.
if err != nil {
return nil, err
}
defer out.Close()

Check warning

Code scanning / CodeQL

Writable file handle closed without error handling

File handle may be writable as a result of data flow from a [call to OpenFile](1) and closing it may result in data loss upon failure, which is not handled explicitly.
if err != nil {
return nil, err
}
defer tty.Close()

Check warning

Code scanning / CodeQL

Writable file handle closed without error handling

File handle may be writable as a result of data flow from a [call to OpenFile](1) and closing it may result in data loss upon failure, which is not handled explicitly.
Signed-off-by: Marvin Strangfeld <[email protected]>
@overfl0
Copy link

overfl0 commented Oct 30, 2024

@albinvass would you be willing to take a look at the current conflicts and resolve them, as felixfontein said that he could try to take a look at it and maybe do something about it, here: #1134 (review)

Maybe there is a chance to finally have this merged :)

@haoqixu
Copy link
Contributor

haoqixu commented Dec 1, 2024

Hi. I have submitted another PR #1692 to continue #1134. @overfl0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants