pgp: don't shorten key fingerprints #1522
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tilpner
force-pushed
the
dont-shorten-key-ids
branch
2 times, most recently
from
685c48e to
3068ed0
Compare
If shortening fingerprints, the trailing '!' from subkey fingerprints is removed, and the wrong key is selected later on, potentially resulting in just-created secrets not being decryptable. Fixes getsops#1365 Signed-off-by: tilpner <[email protected]>
tilpner
force-pushed
the
dont-shorten-key-ids
branch
from
3068ed0 to
574bc8c
Compare
Contributor
I also don't know whether this is still needed, but to avoid breaking changes for users I've created a PR which keeps the trimming, but makes sure to handle I think eventually we should remove the trimming function (as implemented in this PR), but I'm not sure when it's time to do that. Though definitely not in a bugfix release :) |
|
Since the original problem this PR aimed to fix was solved by #1720, I think this can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @mammothbane already identified in #1365, the pgp module is stripping the trailing exclamation mark from fingerprints that pgp uses to identify specific subkeys.
Because the shortened fingerprint refers to the whole key instead of just the subkey, I can't decrypt any secrets I encrypt for that subkey.
According to the doc comment, this was meant for compatibility with older GPG versions. I don't know which incompatibilities @hiddeco was referring to here, or if they are still relevant.
sops/pgp/keysource.go
Lines 633 to 635 in 1c46d24
Fixes #1365