Skip to content

Allow non-string, non-complex values in dotenv output format and exec-env #1914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
billy4479 wants to merge 2 commits into from
Closed

Allow non-string, non-complex values in dotenv output format and exec-env #1914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d9c69c
Avoid panic when values are numbers
billy4479 Aug 17, 2025
66105e9
Allow for non-string values in exec-env
billy4479 Aug 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cmd/sops/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,10 +251,13 @@ func main() {
if strings.Contains(key, "=") {
return cli.NewExitError(fmt.Errorf("cannot use keys with '=' in environment: %s", key), codes.ErrorGeneric)
}

value, ok := item.Value.(string)
if !ok {
return cli.NewExitError(fmt.Errorf("cannot use non-string values in environment, got %T", item.Value), codes.ErrorGeneric)
value = fmt.Sprintf("%v", item.Value)
}

value = strings.ReplaceAll(value, "\n", "\\n")
Copy link
Contributor

@felixfontein felixfontein Aug 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is definitely wrong and must not be there.

Suggested change
value = strings.ReplaceAll(value, "\n", "\\n")

env = append(env, fmt.Sprintf("%s=%s", key, value))
}

Expand Down
7 changes: 6 additions & 1 deletion stores/dotenv/store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,12 @@ func (store *Store) EmitPlainFile(in sops.TreeBranches) ([]byte, error) {
if comment, ok := item.Key.(sops.Comment); ok {
line = fmt.Sprintf("#%s\n", comment.Value)
} else {
value := strings.Replace(item.Value.(string), "\n", "\\n", -1)
value, ok := item.Value.(string)
if !ok {
value = fmt.Sprintf("%v", item.Value)
}

value = strings.ReplaceAll(value, "\n", "\\n")
Comment on lines +147 to +149
Copy link
Contributor

@felixfontein felixfontein Aug 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The replace only makes sense for strings:

Suggested change
}
value = strings.ReplaceAll(value, "\n", "\\n")
} else {
value = strings.ReplaceAll(value, "\n", "\\n")
}

line = fmt.Sprintf("%s=%s\n", item.Key, value)
}
buffer.WriteString(line)
Expand Down
Loading