-
Notifications
You must be signed in to change notification settings - Fork 22
Php 8.2 8.3 support #384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Php 8.2 8.3 support #384
Changes from all commits
b927af2
7885700
c4ff1bf
9ade037
3584c1d
36e42bb
9493eea
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -3,7 +3,7 @@ on: [ push, pull_request_target ] | |||
|
||||
jobs: | ||||
php8-1: | ||||
name: Unit Tests php8.1 (php ${{ matrix.php-version }}) | ||||
name: Unit Tests Php 8.1 (php ${{ matrix.php-version }}) | ||||
runs-on: ubuntu-latest | ||||
# always run on push events | ||||
# only run on pull_request_target event when pull request pulls from fork repository | ||||
|
@@ -31,28 +31,38 @@ jobs: | |||
|
||||
- run: composer test | ||||
|
||||
php8-4: | ||||
name: Unit Tests php8.4 (php ${{ matrix.php-version }}) | ||||
unit-tests: | ||||
# The name is now dynamic based on the custom name set in the matrix. | ||||
name: ${{ matrix.job-name }} | ||||
runs-on: ubuntu-latest | ||||
# always run on push events | ||||
# only run on pull_request_target event when pull request pulls from fork repository | ||||
# Your original conditions for running the job are preserved. | ||||
if: > | ||||
github.event_name == 'push' || | ||||
github.event_name == 'pull_request_target' && github.event.pull_request.head.repo.full_name != github.repository | ||||
(github.event_name == 'pull_request_target' && github.event.pull_request.head.repo.full_name != github.repository) | ||||
strategy: | ||||
fail-fast: false | ||||
matrix: | ||||
php-version: [ 8.4 ] | ||||
# Using include allows us to set custom variables for each job combination. | ||||
include: | ||||
- php-version: 8.2 | ||||
job-name: "Unit Tests (PHP 8.2)" | ||||
- php-version: 8.3 | ||||
job-name: "Unit Tests (PHP 8.3)" | ||||
- php-version: 8.4 | ||||
job-name: "Unit Tests (PHP 8.4)" | ||||
|
||||
steps: | ||||
- uses: actions/checkout@v2 | ||||
# It's best practice to use the latest major version of actions. | ||||
- uses: actions/checkout@v4 | ||||
|
||||
- uses: shivammathur/setup-php@2.9.0 | ||||
- uses: shivammathur/setup-php@v2 | ||||
with: | ||||
php-version: ${{ matrix.php-version }} | ||||
# Optional: Add extensions if needed, for example: | ||||
# extensions: mbstring, intl, gd | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [nitpick] Commented-out configuration example should be removed. This adds unnecessary clutter to the workflow file without providing functional value.
Suggested change
Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||
|
||||
# Remove php-cs-fixer until compatible with PHP 8 | ||||
# This step might be removable if php-cs-fixer is compatible with 8.4 by the time this runs | ||||
# This step to remove php-cs-fixer is kept from your original file. | ||||
# You may want to confirm if it's still needed for both PHP versions. | ||||
- run: composer remove --dev --no-update --no-interaction friendsofphp/php-cs-fixer | ||||
|
||||
- run: composer self-update | ||||
|
@@ -61,6 +71,7 @@ jobs: | |||
|
||||
- run: composer test | ||||
|
||||
|
||||
php7-4: | ||||
name: Unit Tests php7.4 (php ${{ matrix.php-version }}) | ||||
runs-on: ubuntu-latest | ||||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,15 +1,15 @@ | ||||||
{ | ||||||
"name": "yoti/yoti-php-sdk", | ||||||
"description": "Yoti SDK for quickly integrating your PHP backend with Yoti", | ||||||
"version": "4.4.0", | ||||||
"version": "4.4.1", | ||||||
"keywords": [ | ||||||
"yoti", | ||||||
"sdk" | ||||||
], | ||||||
"homepage": "https://yoti.com", | ||||||
"license": "MIT", | ||||||
"require": { | ||||||
"php": "^7.4 || ^8.0 || ^8.1 || ^8.4", | ||||||
"php": "^7.4 || ^8.0 || ^8.1 || ^8.2 || ^8.4", | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. PHP 8.3 support is missing from the version constraint. The PR title mentions PHP 8.3 support, but it's not included in the composer.json requirements.
Suggested change
Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||
"ext-json": "*", | ||||||
"google/protobuf": "^3.10", | ||||||
"phpseclib/phpseclib": "^3.0", | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent action version pinning. checkout uses @v4 (major version) while setup-php uses @v2. Consider using specific versions like @v2.9.0 for reproducible builds or consistently use major versions.
Copilot uses AI. Check for mistakes.