Skip to content

Conversation

@mehmet-yoti
Copy link
Contributor

No description provided.

@sonarqubecloud
Copy link

@mehmet-yoti
Copy link
Contributor Author

@copilot please using below prompt add needed feature.

"To implement support for the brand_id in the IDV iframe session creation within the SDKs, we will follow a detailed implementation plan. Below is a breakdown of the subtasks and steps required to complete this task, ensuring compatibility and testing for the new feature across all relevant platforms:\n\n### 1. Analyze Requirements\n- Review Documentation: Examine any available documentation or resources provided by the IDV team regarding the brand_id property, including its usage and constraints.\n- Understand Existing SDK Structure: Familiarize yourself with the current codebase of the SDKs to understand where and how session configurations are handled.\n\n### 2. Design the Solution\n- Define Schema Updates: Determine how the existing SDK session configuration schemas need to be updated to include the brand_id.\n- Backward Compatibility Consideration: Ensure that introducing brand_id will not affect users who do not use this property.\n\n### 3. Update SDK Codebase\n#### 3.1 Backend SDKs (e.g., Node.js, Java, Python)\n- Modify Configuration Objects: Update the SDK session configuration class or function to include brand_id as an optional parameter.\n- Update Initialization Code: Modify the session creation logic to accept and process the brand_id parameter.\n- Error Handling: Implement error handling to manage cases where brand_id is invalid or not recognized.\n\n#### 3.2 Frontend SDKs (e.g., JavaScript/TypeScript)\n- Update Initialization Script: Ensure the session initializer can accept brand_id and pass it to the relevant methods or endpoints.\n- UI Considerations: Ensure any UI components respect the brand theming, if applicable.\n\n### 4. Testing\n- Unit Tests: Write and update unit tests to validate that brand_id is correctly handled within the codebase. Ensure tests are added for cases where brand_id is provided and not provided.\n- Integration Tests: Conduct integration tests to ensure the SDK correctly interacts with the IDV library or backend services when brand_id is present.\n- Regression Tests: Perform regression testing on the session creation process to ensure existing functionality remains intact.\n\n### 5. Documentation\n- Update SDK Documentation: Revise the public SDK documentation to include instructions on how to use the brand_id property when creating a session.\n- Changelog Entry: Add an entry to the changelog detailing the addition of the brand_id support.\n\n### 6. Code Review and Approval\n- Internal Review: Conduct a peer review of the implemented changes to ensure code quality and adherence to best practices.\n- External Feedback: If applicable, seek feedback from the IDV team to verify the implementation meets the specifications and expected usage scenarios.\n\n### 7. Release and Deployment\n- Versioning: Update the version of the SDKs that include the brand_id feature.\n- Deployment: Deploy the updated SDKs to the appropriate package managers (e.g., npm, Maven, PyPI).\n\n### 8. Post-Deployment Verification\n- Monitor Logs: After release, monitor application logs and customer feedback for issues related to the new feature.\n- Bug Fixes: Address any bugs or issues that arise swiftly as part of the post-release maintenance.\n\nThis implementation plan should ensure a structured approach to adding brand_id support to the SDKs, maintaining quality and usability throughout the process.",

Copy link

Copilot AI commented Nov 27, 2025

@mehmet-yoti I've opened a new pull request, #427, to work on those changes. Once the pull request is ready, I'll request review from you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants