Skip to content

Revert #236 - env already supported#246

Merged
harshal-shah merged 2 commits intomasterfrom
revert-pr-236
Mar 27, 2025
Merged

Revert #236 - env already supported#246
harshal-shah merged 2 commits intomasterfrom
revert-pr-236

Conversation

@alexef
Copy link
Copy Markdown
Member

@alexef alexef commented Mar 27, 2025

Proposed change

see comment: #236 (comment)

How to test the change

Checklist

  • Tests have been added to verify that the new code works (if possible)
  • Documentation has been updated to reflect changes
  • CHANGELOG.md has been updated to reflect changes

@alexef alexef requested a review from a team as a code owner March 27, 2025 07:25
@alexef alexef requested a review from daniddelrio March 27, 2025 07:26
@harshal-shah harshal-shah merged commit f8b04f0 into master Mar 27, 2025
5 checks passed
@harshal-shah harshal-shah deleted the revert-pr-236 branch March 27, 2025 07:49
@tplass-ias
Copy link
Copy Markdown
Contributor

can you re-add the docs? I have users of this repo that aren't going to decipher the code

@tplass-ias
Copy link
Copy Markdown
Contributor

you also reverted my test, so it is not clear in the new code state even from the example code executions in the repo that this env var is supported 😭

@alexef
Copy link
Copy Markdown
Member Author

alexef commented Mar 27, 2025

@tplass-ias sure thing, will do: #247

@tplass-ias
Copy link
Copy Markdown
Contributor

also, does this now require the token to exist in the config file again? I don't want to share a file with a github token, I do want to share a file with the execution state of auto-pr

@tplass-ias
Copy link
Copy Markdown
Contributor

tplass-ias commented Mar 27, 2025

yeah actually, @alexef please fully restore, the env var needs to be supported in run(), not just init() like the other person pointed out. By reverting this PR, you are forcing me to store the token in db.json again, which is exactly what I want to avoid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants