Merged
Conversation
gygAlexWeiss
approved these changes
Jan 27, 2025
Collaborator
gygAlexWeiss
left a comment
gygAlexWeiss
left a comment
There was a problem hiding this comment.
Took me a moment to understand what you're doing here. Understood. Looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We hit a rare issue in the CI run here -- one test,
test_seed_not_provided, failed. This didn't have anything to do with the commit, though -- instead, it's an issue with the test. We callevaluate_experimentwith a small number of samples and -1 overall successes, and this leads to us doing the 'coin flip' to check whether this test experiment might have 'crossed the line'. In this case there's a small (~1%) chance for us to 'fail' the coin flip and get a different result than we normally expect in the test, and that's what happened here.We avoid this in other tests by setting the seed, but this is the one test where we deliberately don't do that and test the behaviour. So, the fix is to make the test deterministic in other ways. This PR helps us bypass the coin flip by making sure the probability is zero in our first call (by logging no samples at all) and then all the required samples at once in the second call.