Skip to content

update: Support request bodies on all methods #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2024
+7 −10
Merged

update: Support request bodies on all methods #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions ...rc/main/java/com/getyourguide/openapi/validation/filter/OpenApiValidationInterceptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,12 +155,6 @@ private List<OpenApiViolation> validateRequest(
}

private static String readBodyCatchingException(MultiReadContentCachingRequestWrapper request) {
if (!"POST".equalsIgnoreCase(request.getMethod())
&& !"PUT".equalsIgnoreCase(request.getMethod())
&& !"PATCH".equalsIgnoreCase(request.getMethod())) {
return null;
}

try {
return StreamUtils.copyToString(request.getInputStream(), StandardCharsets.UTF_8);
} catch (IOException e) {
Expand Down
11 changes: 7 additions & 4 deletions ...est/java/com/getyourguide/openapi/validation/filter/OpenApiValidationInterceptorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
import com.getyourguide.openapi.validation.api.model.OpenApiViolation;
import java.util.List;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.ValueSource;
import org.springframework.web.server.ResponseStatusException;

class OpenApiValidationInterceptorTest extends BaseFilterTest {
Expand Down Expand Up @@ -104,15 +106,16 @@ public void testShouldFailOnRequestViolationWithViolation() {
verifyNoResponseValidation();
}

@Test
public void testShouldIgnoreBodyOnGetRequests() {
var mockData = mockSetup(MockConfiguration.builder().requestBody("{\"field\": 1}}").requestMethod("GET").build());
@ParameterizedTest
@ValueSource(strings = {"GET", "POST", "PUT", "PATCH", "DELETE"})
public void testShouldSupportBodyOnGetRequests(String requestMethod) {
var mockData = mockSetup(MockConfiguration.builder().requestBody("{\"field\": 1}}").requestMethod(requestMethod).build());

httpInterceptor.preHandle(mockData.request(), mockData.response(), new Object());
httpInterceptor.postHandle(mockData.request(), mockData.response(), new Object(), null);
httpInterceptor.afterCompletion(mockData.request(), mockData.response(), new Object(), null);

verifyRequestValidatedAsync(mockData, null);
verifyRequestValidatedAsync(mockData, "{\"field\": 1}}");
verifyResponseValidatedAsync(mockData);
}

Expand Down
Loading